Trim down xtensa crates #2357
Draft
Trim down xtensa crates #2357
+132
−299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Oct 16, 2024
|
esp-rs/esp-pacs#282 has been merged, I think we can get this ready now. |
|
What should we do about Or should we just provide a single-core feature and implemet a single-core critical section in xtensa-lx? I'm not entirely sure how far we want to generalize this crate at this moment. I'm also not sure whether that question is in scope of this PR :) |
bugadani
force-pushed
the
lx
branch
3 times, most recently
from
de95efa
to
b9b8829
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
bugadani
force-pushed
the
lx
branch
2 times, most recently
from
ef8ef47
to
fbda4bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some legacy code from the xtensa crates.