-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with keeper compensation #451
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9aa7e03
integrated Arjun's changes
EdNoepel 5dc8ced
gas measurement for trigger orders
EdNoepel d11953a
keeperConfig for withdrawals
EdNoepel 0db3380
measure gas spent in the TX
EdNoepel 11cb05a
compare gas spent under test to DSU fee earned by keeper
EdNoepel 3da24a7
handle multiple commitments
EdNoepel d7c99ba
remove logging
EdNoepel 78365e5
add buffered keepConfig to trigger orders
EdNoepel 20a7e97
moved collateral account keeper configs to initializer
EdNoepel c651ec4
prevent double-read of order needed for keep modifier
EdNoepel e6a2494
update test to reconcile fees against consumed gas
EdNoepel e4bed21
unrelated spelling correction
EdNoepel 30a8c29
remove unused import
EdNoepel 6fb2320
Merge branch 'v2.3-fix-review' into ed/92-keeper-configs
EdNoepel 2b43fc8
Merge branch 'v2.3-fix-review' into ed/92-keeper-configs
EdNoepel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we handling deposits now that we always charge the fee afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A "full deposit" is a corner case because fees are always paid from the account. If a user was able to transfer their entire collateral account into one or more markets, they could not pay a keeper to rebalance. When we last discussed this, we concluded an accurate gas calculation is worth the UX tradeoff.