-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with keeper compensation #451
Conversation
_marketTransferWithSignature(account, marketTransfer, signature); | ||
_handleKeeperFee(keepConfig, 0, msg.data[0:0], 0, data); | ||
} | ||
_marketTransferWithSignature(account, marketTransfer, signature); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we handling deposits now that we always charge the fee afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A "full deposit" is a corner case because fees are always paid from the account. If a user was able to transfer their entire collateral account into one or more markets, they could not pay a keeper to rebalance. When we last discussed this, we concluded an accurate gas calculation is worth the UX tradeoff.
|
[Periphery] Unit Test Coverage ReportCoverage after merging ed/92-keeper-configs into v2.3-fix-review will be
Coverage Report
|
[Core] Integration Test Coverage ReportCoverage after merging ed/92-keeper-configs into v2.3-fix-review will be
Coverage Report
|
[Periphery] Integration Test Coverage ReportCoverage after merging ed/92-keeper-configs into v2.3-fix-review will be
Coverage Report
|
[Periphery] Combined Test Coverage ReportCoverage after merging ed/92-keeper-configs into v2.3-fix-review will be
Coverage Report
|
[Core] Unit Test Coverage ReportCoverage after merging ed/92-keeper-configs into v2.3-fix-review will be
Coverage Report
|
[Core] Combined Test Coverage ReportCoverage after merging ed/92-keeper-configs into v2.3-fix-review will be
Coverage Report
|
Fixes sherlock-audit/2024-08-perennial-v2-update-3-judging#92