Verification UI / UX iteration

[bmarty]

Content

Iterate on a few screens of the verification flows

Motivation and context

Closes #3824

Screenshots / GIFs

See the recorded screenshots

Tests

• Perform a login followed by a session verification using another device
• From an other device, perform a session verification flow.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zBvn5w

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (213dc77) to head (88d0498).
Report is 13 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ion/impl/outgoing/VerifySelfSessionStateMachine.kt	83.33%	0 Missing and 1 partial ⚠️
...rifysession/impl/outgoing/VerifySelfSessionView.kt	95.65%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3829   +/-   ##
========================================
  Coverage    82.98%   82.99%           
========================================
  Files         1782     1782           
  Lines        44860    44881   +21     
  Branches      5265     5277   +12     
========================================
+ Hits         37228    37247   +19     
  Misses        5793     5793           
- Partials      1839     1841    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

LGTM, thanks!

It feels kind of weird having a 'done' action on a verification failed screen, but if it's what was designed then 🤷 .