Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable button during the "verifying" step. #3832

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 7, 2024

@bmarty bmarty requested a review from a team as a code owner November 7, 2024 17:33
@bmarty bmarty requested review from ganfra and removed request for a team November 7, 2024 17:33
@bmarty bmarty marked this pull request as draft November 7, 2024 17:34
Copy link
Contributor

github-actions bot commented Nov 7, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/F2g1YA

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (bee708c) to head (82f150b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3832   +/-   ##
========================================
  Coverage    83.00%   83.00%           
========================================
  Files         1782     1782           
  Lines        44889    44890    +1     
  Branches      5278     5278           
========================================
+ Hits         37261    37262    +1     
  Misses        5791     5791           
  Partials      1837     1837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Change For updates to an existing feature labels Nov 7, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 7, 2024
@ElementBot
Copy link
Collaborator

ElementBot commented Nov 7, 2024

Messages
📖 Sign-off not required, allow-list

Generated by 🚫 dangerJS against 31f1534

Copy link

sonarcloud bot commented Nov 7, 2024

@@ -118,6 +119,14 @@ fun TextButton(
leadingIcon = leadingIcon
)

@Composable
fun InvisibleButton(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bit weird to have an InvisibleButton api?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants