Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate breasking changes due to rust-sdk update 0.2.57 #3736

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Integrate breasking changes due to rust-sdk update 0.2.57 #3736

merged 3 commits into from
Oct 24, 2024

Conversation

BillCarsonFr
Copy link
Member

Content

Can be reviewed commit per commit

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@BillCarsonFr BillCarsonFr mentioned this pull request Oct 24, 2024
Merged
10 tasks
@ElementBot
Copy link
Collaborator

Fails
🚫

Please add a PR- label to categorise the changelog entry.
Messages
📖 Sign-off not required, allow-list

Generated by 🚫 dangerJS against 4f3ccf3

@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xqLtuj

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BillCarsonFr BillCarsonFr marked this pull request as ready for review October 24, 2024 09:55
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner October 24, 2024 09:55
@BillCarsonFr BillCarsonFr requested review from jmartinesp and removed request for a team October 24, 2024 09:55
jmartinesp
jmartinesp approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Base automatically changed from feature/valere/support_new_utd_causes to feature/valere/bump_rust_sdk_0.2.57 October 24, 2024 12:26
@BillCarsonFr BillCarsonFr merged commit a07d102 into feature/valere/bump_rust_sdk_0.2.57 Oct 24, 2024
22 of 25 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/valere/stack_3_bump_sdk_0.2.57_subscription branch October 24, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillCarsonFr @ElementBot @jmartinesp