-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rust-sdk version to rust-sdk 0.2.57 #3735
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistPreviewTest.kt
Outdated
Show resolved
Hide resolved
LocalEventSendState.Failed.SendingFromUnverifiedDevice | ||
} | ||
is QueueWedgeError.IdentityViolations -> { | ||
// smart cast impossible because 'error' is a public API property declared in different module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the screenshot will be recorded, I'll push a commit to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3735 +/- ##
========================================
Coverage 83.05% 83.05%
========================================
Files 1754 1754
Lines 43980 43994 +14
Branches 5142 5142
========================================
+ Hits 36526 36540 +14
+ Misses 5633 5632 -1
- Partials 1821 1822 +1 ☔ View full report in Codecov by Sentry. |
adf4442
to
4ef231c
Compare
Quality Gate passedIssues Measures |
Ah, my bad, I re-ran Maestro when it had already succeeded before. |
Content
Base PR to update all breaking changes with the new rust-sdk version. Do not merge yet.
Here is the stak of PR to be merged on this one:
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist