Some rework on the codebase

[bmarty]

This PR now includes only rework that I want to merge on develop first. So no change in UI and in behavior. Just renaming and clean up.

A following PR will come with the change about notification counts.

- First commit: #2080 again, which had been reverted in #2095. - Second commit new version of the SDK, which fix the "RoomInfo.notificationCount always equal to 0" issue - Thrid commit: map `RoomInfo.notificationCount` to `RoomSummaryDetails.numUnreadMessages`, since `RoomInfo.numUnreadMessages` still have some issue. This thrid commit may be reverted at some point.

The behavior of the notification badges in the room list should be similar to the iOS app with this change.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VE8VEG

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (72253c0) 69.95% compared to head (ec7badf) 70.01%.
Report is 12 commits behind head on develop.

Files	Patch %	Lines
...cations/edit/EditDefaultNotificationSettingView.kt	50.00%	0 Missing and 1 partial ⚠️
...eatures/roomlist/impl/components/RoomSummaryRow.kt	50.00%	0 Missing and 1 partial ⚠️
.../notifications/DefaultNotificationDrawerManager.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2130      +/-   ##
===========================================
+ Coverage    69.95%   70.01%   +0.05%     
===========================================
  Files         1335     1335              
  Lines        32666    32660       -6     
  Branches      6790     6791       +1     
===========================================
+ Hits         22853    22868      +15     
+ Misses        6536     6514      -22     
- Partials      3277     3278       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

I'm still seeing an issue I saw before we reverted this: when a room has a previous message with a mention to you, received while the app wasn't running, the unread count and mention won't be gone until a new message in that room (not coming from the current user) is received.

I'm wondering if we should merge it in this state?

[jmartinesp]

Could we do the same as iOS, and use a feature flag to decide whether to use the legacy behaviour for this, or this new one?

[bmarty]

Could we do the same as iOS, and use a feature flag to decide whether to use the legacy behaviour for this, or this new one?

Yes, we could. I wanted to avoid this, but if it helps, let's do it.

[bmarty]

I'm still seeing an issue I saw before we reverted this: when a room has a previous message with a mention to you, received while the app wasn't running, the unread count and mention won't be gone until a new message in that room (not coming from the current user) is received.

Can we "accept" this as a limitation, and open an issue somewhere (on the Rut side?), to unblock this PR again?

I do not want to add a feature flag to mitigate this. Let's keep it simple. Do you agree @jmartinesp?

[jmartinesp]

I do not want to add a feature flag to mitigate this. Let's keep it simple. Do you agree @jmartinesp?

I think it would be better to have a FF since the new behaviour is not working that well, and can make the users believe we also have stuck 'notifications' as in EW. Maybe it's better to wait until matrix-org/matrix-rust-sdk#2978 is merged an check if that fixes the issue?

If you think we should merge it as is we can do that, I'm just a bit reluctant to do it because of how users might react if the app starts behaving weirdly here.

[bmarty]

matrix-org/matrix-rust-sdk#2978 has just been merged 🎉 . I will do some test with it.

[bmarty]

@jmartinesp splitting the PR to 2 parts. First part is some rework, and once merged I will create another PR for the change about notification count.

[bmarty]

I will iterate to ensure that existing screenshots do not change.

[bmarty]

OK, I will record screenshot because actually the current preview is better (latest message with timestamp). There is less change, so that's fine.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[jmartinesp]

LGTM, thanks!

[bmarty]

Having a timestamp and no last message should not happen, but I will fix in a future PR (in #2265)