Room list room summary cleanup

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other : cleanup codebase

Content

Following #2130, there were more cleanup to do.

Motivation and context

Be ready for #2265 to (be rebased and) land properly.

Screenshots / GIFs

Tests

• Nothing should be broken.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[bmarty]

id has changed, and so the avatar color.

[bmarty]

no timestamp if no message.

[jmartinesp]

I'm fine with not displaying the timestamp if there's no last message, but DefaultLastMessageFormatter has a CharSequence? return type that could return null even if there is a last message formatted, so you'd see the room item at the top of the list when it's updated, but you wouldn't see a timestamp if I'm not mistaken, which would look weird.

Could we change this return type to CharSequence and make sure we always return a String, even an empty one, if there is a last message for the room? So if there is a last event we always return something (maybe empty, but something) and if there really is nothing we return null.

[bmarty]

I'm fine with not displaying the timestamp if there's no last message

I did not change any logic in the existing codebase, just wanted to have more coherent previews. But you're right, since DefaultLastMessageFormatter can return null, we can have a room list item with no message and a timestamp. So the previous screenshot may reflect something that can happen.

if we want to change this, it should be done in a separate PR, as this one is only rework with no logical change.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Jcn9An

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c3538e5) 70.04% compared to head (bbd8710) 70.05%.

Files	Patch %	Lines
...res/roomlist/impl/datasource/RoomListDataSource.kt	50.00%	0 Missing and 2 partials ⚠️
...list/impl/datasource/RoomListRoomSummaryFactory.kt	94.73%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2273      +/-   ##
===========================================
+ Coverage    70.04%   70.05%   +0.01%     
===========================================
  Files         1335     1335              
  Lines        32674    32684      +10     
  Branches      6792     6793       +1     
===========================================
+ Hits         22885    22896      +11     
  Misses        6512     6512              
+ Partials      3277     3276       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[jmartinesp]

LGTM if the CI passes.