Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix power guards #476

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Fix power guards #476

merged 7 commits into from
Oct 23, 2023

Conversation

M0stafaRady
Copy link
Member

No description provided.

RTimothyEdwards
RTimothyEdwards previously requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not continue to ignore caravan, and now, also openframe.

@M0stafaRady M0stafaRady requested a review from jeffdi June 14, 2023 09:24
@jeffdi jeffdi dismissed RTimothyEdwards’s stale review October 23, 2023 14:52

change was implemented

@jeffdi
Copy link
Collaborator

jeffdi commented Oct 23, 2023

Reviewed signoff impact. Changes only affect simulation.

@jeffdi jeffdi merged commit 4996d33 into main Oct 23, 2023
1 of 3 checks passed
@jeffdi jeffdi deleted the remove_depency_over_power branch October 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdi jeffdi jeffdi approved these changes

@shalan shalan Awaiting requested review from shalan

@RTimothyEdwards RTimothyEdwards Awaiting requested review from RTimothyEdwards

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M0stafaRady @jeffdi @RTimothyEdwards