Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more improvements about the I18n support #66

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

macagua
Copy link

@macagua macagua commented Aug 21, 2023

Hi @avoinea

I fix the error about "intl" reference no found, also test the addon using the command "make project", and run the backend and frontend by separate, I test the addon, adding a "Tabs block", and set it, for many example using the template options avalaible.

@macagua
Copy link
Author

macagua commented Aug 21, 2023

@avoinea Can you checkout this pull request, if all ok can you merge it? I hope this time that all QA checkouts pass

@ichim-david
Copy link
Member

Hi @macagua
I went ahead for this release to merge this pull request #62
which I have checked and it worked bringing in pt-br and Spanish translation.
Can you please merge the changes from our develop branch in your fork and make the necessary merge
changes so that we only add any i18n strings that are not already translated from that pull request?
Thank you for your effort.

@avoinea avoinea marked this pull request as draft November 24, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants