Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify for Azure TDX with Terraform provider #3449

Merged
merged 5 commits into from
Oct 25, 2024
Merged

docs: clarify for Azure TDX with Terraform provider #3449

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a6ed2f
add snp and tdx distinction for tf docs
elchead Oct 22, 2024
e958c2a
add comment to adjust instance type for tdx
elchead Oct 22, 2024
cd12f21
fixup! add snp and tdx distinction for tf docs
elchead Oct 22, 2024
0651847
moritz feedback
elchead Oct 24, 2024
81f4d34
update 2.19 docs
elchead Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion docs/docs/workflows/terraform-provider.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@
Optionally, you can prefix the `terraform apply` command with `TF_LOG=INFO` to collect [Terraform logs](https://developer.hashicorp.com/terraform/internals/debugging) while applying the configuration. This may provide helpful output in debugging scenarios.
</TabItem>
<TabItem value="azure" label="Azure">
When creating a cluster on Azure, you need to manually patch the policy of the MAA provider before creating the Constellation cluster, as this feature isn't available in Azure's Terraform provider yet. The Constellation CLI provides a utility for patching, but you

elchead marked this conversation as resolved.
Show resolved Hide resolved
<Tabs groupId="variant">
<TabItem value="sevsnp" label="SEV-SNP">
When creating a cluster with SEV-SNP, you need to manually patch the policy of the MAA provider before creating the Constellation cluster, as this feature isn't available in Azure's Terraform provider yet. The Constellation CLI provides a utility for patching, but you

Check warning on line 40 in docs/docs/workflows/terraform-provider.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Microsoft.SentenceLength] Try to keep sentences short (< 30 words).

Raw Output:
{"message": "[Microsoft.SentenceLength] Try to keep sentences short (\u003c 30 words).", "location": {"path": "docs/docs/workflows/terraform-provider.md", "range": {"start": {"line": 40, "column": 3}}}, "severity": "WARNING"}
can also do it manually.

```bash
Expand Down Expand Up @@ -68,6 +71,19 @@
```

</TabItem>
<TabItem value="tdx" label="TDX">
Initialize the providers and apply the configuration.

```bash
terraform init
terraform apply
```

Optionally, you can prefix the `terraform apply` command with `TF_LOG=INFO` to collect [Terraform logs](https://developer.hashicorp.com/terraform/internals/debugging) while applying the configuration. This may provide helpful output in debugging scenarios.
</TabItem>
</Tabs>
</TabItem>

<TabItem value="gcp" label="GCP">
Initialize the providers and apply the configuration.

Expand Down
2 changes: 1 addition & 1 deletion terraform-provider-constellation/examples/full/azure/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ locals {
location = "northeurope"
control_plane_count = 3
worker_count = 2
instance_type = "Standard_DC4as_v5"
instance_type = "Standard_DC4as_v5" // needs to be changed for azure-tdx
elchead marked this conversation as resolved.
Show resolved Hide resolved
subscription_id = "00000000-0000-0000-0000-000000000000"

master_secret = random_bytes.master_secret.hex
Expand Down