docs: clarify for Azure TDX with Terraform provider #3449
Merged
+33
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
msanft
requested changes
Oct 22, 2024
elchead
force-pushed
the
as/fix-tf-docs
branch
from
09f3b2f
to
0651847
Compare
msanft
approved these changes
Oct 24, 2024
thomasten
approved these changes
Oct 25, 2024
elchead
added
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current provider docs don't distinguish Azure SEV-SNP and TDX, even though the steps are not the same.
Also, I noticed that the TF code doesn't validate the instance type for the given attestation variant. Thus, a user might forget to change this field when using TDX. The validation cannot be easily included because infra and constellation resources are strictly separated in TF, but a comment seems like a good enough hint.
Proposed change(s)
Additional info
Checklist