Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tests failing in Test_org_eclipse_swt_browser_Browser #1564

Open
fedejeanne opened this issue Oct 30, 2024 · 5 comments
Open

Multiple tests failing in Test_org_eclipse_swt_browser_Browser #1564

fedejeanne opened this issue Oct 30, 2024 · 5 comments
Assignees
Labels
junit JUnit test failure Linux/GTK Happens on Linux

Comments

@fedejeanne
Copy link
Contributor

These 3 tests fail on Linux. I noticed in this run of #1496 and I was also able to reproduce it locally using WSL2:

  • org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_OpenWindowListener_open_ChildPopup()
  • org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_OpenWindow_Progress_Listener_ValidateEventOrder()
  • org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_VisibilityWindowListener_eventSize()

It seems to be some issue with JavaScript (just my guess), here are some screenshots (WSL2):

image

image

image

All 3 tests timed out.

@fedejeanne fedejeanne added junit JUnit test failure Linux/GTK Happens on Linux labels Oct 30, 2024
@jukzi
Copy link
Contributor

jukzi commented Oct 30, 2024

"More" is a comparison. Did you mean "Multiple" which is a numeric? Is the failure always reproduceable or random?

@fedejeanne fedejeanne changed the title More tests failing in Test_org_eclipse_swt_browser_Browser Multiple tests failing in Test_org_eclipse_swt_browser_Browser Oct 30, 2024
@fedejeanne
Copy link
Contributor Author

"More" is a comparison. Did you mean "Multiple" which is a numeric? Is the failure always reproduceable or random?

I originally meant "more" because I wanted to mention the other tests that are failing (for which there is already an issue) but I changed my mind to avoid confusion. I changed the title now, thank you for the pointer.

The tests fail very consistently when I run them locally. I am not sure about the failures in the pipelines though, I've only seen them failing in my own PRs.

@HeikoKlare
Copy link
Contributor

I can reproduce the failures locally on Ubuntu 24.04.1, Webkit 2.46.1. Tests fail with both X11 and Wayland.
When debugging the code, I found that the JavaScript used to open a child window is not even executed. JavaScript is properly enabled for the browser.

When I use the WebKit browser inside Eclipse and navigate to an HTML file that contains the same code as passed to the browser in the test, a child window pops up as expected.
So may the problem be related to some (new) restriction regarding what WebKitGTK#webkit_web_view_load_html() (called by Browser#setText()) is allowed to do?

@HannesWell
Copy link
Member

In tonight's I-build these tests now fail for all java versions 17,21 and 23. In the last night's it only failed for 17:
https://download.eclipse.org/eclipse/downloads/drops4/I20241107-1800/testResults.php

I cannot tell if this is related to switching to Ubunut based images for Linux (eclipse-platform/eclipse.platform.releng.aggregator#2522) or if this is all just coincidence.

@akurtakov
Copy link
Member

In tonight's I-build these tests now fail for all java versions 17,21 and 23. In the last night's it only failed for 17: https://download.eclipse.org/eclipse/downloads/drops4/I20241107-1800/testResults.php

I cannot tell if this is related to switching to Ubunut based images for Linux (eclipse-platform/eclipse.platform.releng.aggregator#2522) or if this is all just coincidence.

I believe it's related (e.g. different webkitgtk version) but failing constantly is better than randomly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
junit JUnit test failure Linux/GTK Happens on Linux
Projects
None yet
Development

No branches or pull requests

5 participants