Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back GitHub Actions workflow to use current Tycho version #1488

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Sep 25, 2024

The Tycho version used in GitHub Actions workflow has been temporarily reverted to 4.0.8. This change switched back the Tycho version defined in the Tycho build itself.

Since recent PDE and Tycho changes that apply with this change of the Tycho version, the API filters for GCData and Display on MacOS are not necessary anymore and produce warnings due to being obsolete. Thus, this change also removes the according filters. The commit has been taken from as it semantically belongs to the Tycho version change (and is required to make the CI builds run successfully):

⚠️ This PR is supposed to be merged once the issue discussed in eclipse-platform/eclipse.platform.releng.aggregator#2360 and reproduced via eclipse-tycho/tycho#4293 has been resolved or once we want to have SWT use latest Tycho again to further investigate the failures.

Supercedes and thus closes #1478

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Test Results

   483 files  ±0     483 suites  ±0   8m 32s ⏱️ -24s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 732b288. ± Comparison against base commit e03196c.

♻️ This comment has been updated with latest results.

@HeikoKlare
Copy link
Contributor Author

I've experimentally changed this PR to use Tycho 4.0.10-SNAPSHOT, in order to validate that the reason for temporarily switching back to Tycho 4.0.8 (failures during testCompile on Linux/MacOS) has been resolved.

The builds now successfully pass that compilation step (@laeubi fyi).
They still fail, but for different, unrelated reasons:

I guess there are no plans for releasing Tycho 4.0.10 soon? So would it make sense to upgrade the whole platform to use 4.0.10-SNAPSHOT, or should we maybe at least apply it to the GH actions builds of SWT?

@sratz
Copy link
Member

sratz commented Nov 6, 2024

I guess there are no plans for releasing Tycho 4.0.10 soon?

There are: eclipse-tycho/tycho#2455 (comment)

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2024

I guess there are no plans for releasing Tycho 4.0.10 soon? So would it make sense to upgrade the whole platform to use 4.0.10-SNAPSHOT, or should we maybe at least apply it to the GH actions builds of SWT?

We should use 4.0.10-SNAPSHOT for platform to getting more confident that there are no regressions, so if you like just go ahead and upgrade the aggregator for a while, I'll then take care to release the version before the code freeze.

@HeikoKlare
Copy link
Contributor Author

We should use 4.0.10-SNAPSHOT for platform to getting more confident that there are no regressions, so if you like just go ahead and upgrade the aggregator for a while, I'll then take care to release the version before the code freeze.

Alright, done: eclipse-platform/eclipse.platform.releng.aggregator#2520

The Tycho version used in GitHub Actions workflow has been temporarily
reverted to 4.0.8. This change switched back the Tycho version defined
in the Tycho build itself.
@HeikoKlare HeikoKlare force-pushed the remove-temporary-revert-tycho-4.0.8 branch from 6697e22 to 10f1186 Compare November 7, 2024 10:19
Since recent PDE and Tycho changes, the API filters for GCData and
Display on MacOS are not necessary anymore and produce warnings due to
being obsolete. This removes the according filters.
@HeikoKlare HeikoKlare marked this pull request as ready for review November 7, 2024 12:03
@HeikoKlare
Copy link
Contributor Author

I've changed this PR back to remove the explicit Tycho version specification and use the one of the parent POM again (which is now 4.0.10-SNAPSHOT).
I have also integrated the following change into this as otherwise MacOS builds will fail because of changes in API tools:

For failing tests, see: #1564

@HeikoKlare HeikoKlare merged commit 5bfffc0 into eclipse-platform:master Nov 7, 2024
12 of 14 checks passed
@HeikoKlare HeikoKlare deleted the remove-temporary-revert-tycho-4.0.8 branch November 7, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants