-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back GitHub Actions workflow to use current Tycho version #1488
Switch back GitHub Actions workflow to use current Tycho version #1488
Conversation
Test Results 483 files ±0 483 suites ±0 8m 32s ⏱️ -24s For more details on these failures, see this check. Results for commit 732b288. ± Comparison against base commit e03196c. ♻️ This comment has been updated with latest results. |
1ee3ca7
to
6697e22
Compare
I've experimentally changed this PR to use Tycho 4.0.10-SNAPSHOT, in order to validate that the reason for temporarily switching back to Tycho 4.0.8 (failures during testCompile on Linux/MacOS) has been resolved. The builds now successfully pass that compilation step (@laeubi fyi).
I guess there are no plans for releasing Tycho 4.0.10 soon? So would it make sense to upgrade the whole platform to use 4.0.10-SNAPSHOT, or should we maybe at least apply it to the GH actions builds of SWT? |
There are: eclipse-tycho/tycho#2455 (comment) |
We should use 4.0.10-SNAPSHOT for platform to getting more confident that there are no regressions, so if you like just go ahead and upgrade the aggregator for a while, I'll then take care to release the version before the code freeze. |
Alright, done: eclipse-platform/eclipse.platform.releng.aggregator#2520 |
The Tycho version used in GitHub Actions workflow has been temporarily reverted to 4.0.8. This change switched back the Tycho version defined in the Tycho build itself.
6697e22
to
10f1186
Compare
Since recent PDE and Tycho changes, the API filters for GCData and Display on MacOS are not necessary anymore and produce warnings due to being obsolete. This removes the according filters.
I've changed this PR back to remove the explicit Tycho version specification and use the one of the parent POM again (which is now 4.0.10-SNAPSHOT). For failing tests, see: #1564 |
The Tycho version used in GitHub Actions workflow has been temporarily reverted to 4.0.8. This change switched back the Tycho version defined in the Tycho build itself.
Since recent PDE and Tycho changes that apply with this change of the Tycho version, the API filters for GCData and Display on MacOS are not necessary anymore and produce warnings due to being obsolete. Thus, this change also removes the according filters. The commit has been taken from as it semantically belongs to the Tycho version change (and is required to make the CI builds run successfully):
Supercedes and thus closes #1478