Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32] Fix for refreshing the background image #1576

Conversation

akoch-yatta
Copy link
Contributor

This PR adapts the refreshing of a background image of a control on a DPI change. This must only be done, if the image was set directly on the control.

This commit adapts the refreshing of a background image of a control on a DPI change. This must only be done, if the image was set directly on the control.

Contributes to eclipse-platform#62
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Results

   483 files  ±0     483 suites  ±0   9m 18s ⏱️ +22s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit fe17a1a. ± Comparison against base commit e03196c.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works as expected. And since it only affects code that is executed with the experimental rescaling feature enabled, there is no risk in merging.

@HeikoKlare
Copy link
Contributor

For failing tests, see: #1564

@HeikoKlare HeikoKlare merged commit 342688a into eclipse-platform:master Nov 7, 2024
12 of 14 checks passed
@HeikoKlare HeikoKlare deleted the fix-for-dpi-change-background-image branch November 7, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar Icons in View Stacks Have White Background After Rescaling
2 participants