Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop integration tests for Ruby 2 and Rails 5 #160

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Drop integration tests for Ruby 2 and Rails 5 #160

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86e881f
Fix: default Mail Notify version
mec Aug 23, 2024
2e6e111
Fix: Docker file as to AS
mec Aug 23, 2024
0fde31b
Chore: Update default Rails version
mec Aug 23, 2024
3afb204
Remove Ruby 2 and Rails 5 defaults
mec Aug 23, 2024
b9c1846
Remove Rails 5 from integration tests
mec Aug 23, 2024
0f1f10d
Don't fetch beta Rails version numbers
mec Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ COPY --from=build /rails /rails
WORKDIR /rails/mail-notify-integration

# add Mail Notify to the Gemfile
ARG MAIL_NOTIFY_BRANCH=v2
ARG MAIL_NOTIFY_BRANCH=2.0.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say "we generally pass this argument", do you mean it gets passed in somewhere else, overriding this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, when you build a docker image you can pass in arguments to change the output, it's a common pattern to declare and set a default like this, you see it a lot in this Dockerfile. ARG for images ENV for running containers.

RUN echo "gem 'mail-notify', git: 'https://github.com/dxw/mail-notify', branch: '${MAIL_NOTIFY_BRANCH}'" >> Gemfile

# install the mail-notify gem, we do this here to keep the last container layer small to help caching
Expand Down