Drop integration tests for Ruby 2 and Rails 5 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10523965758Details
💛 - Coveralls |
Whilst we generally pass this argument, it should be `2.0.0`.
mec
force-pushed
the
chore/drop-ruby-2-and-rails-5-int-testing
branch
from
89a8669
to
9a3cf45
Compare
mec
changed the title
We are dropping integration test support for these end of life versions. This work will focus solely on the integration tests and not the gem itself.
mec
force-pushed
the
chore/drop-ruby-2-and-rails-5-int-testing
branch
from
9a3cf45
to
10f676e
Compare
yndajas
approved these changes
Aug 23, 2024
| run: | | ||
| rails_versions=$(curl https://rubygems.org/api/v1/versions/rails.json | jq 'group_by(.number[:1])[] | (.[0].number) | select(.[:1]|tonumber > 5)' | jq -s -c) | ||
| rails_versions=$(curl https://rubygems.org/api/v1/versions/rails.json | jq '[.[] | select(.number | test("beta") | not)] | group_by(.number[:1])[] | (.[0].number) | select(.[:1]|tonumber > 5)' | jq -s -c) |
There was a problem hiding this comment.
I don't know the jq syntax well enough to review this line
There was a problem hiding this comment.
Honestly, me too, I would prefer something less dynamic but more obvious, but happy to trust in this having seen it work.
| @@ -45,7 +45,7 @@ COPY --from=build /rails /rails | |||
| WORKDIR /rails/mail-notify-integration | |||
|
|
|||
| # add Mail Notify to the Gemfile | |||
| ARG MAIL_NOTIFY_BRANCH=v2 | |||
| ARG MAIL_NOTIFY_BRANCH=2.0.0 | |||
There was a problem hiding this comment.
When you say "we generally pass this argument", do you mean it gets passed in somewhere else, overriding this?
There was a problem hiding this comment.
Yep, when you build a docker image you can pass in arguments to change the output, it's a common pattern to declare and set a default like this, you see it a lot in this Dockerfile. ARG for images ENV for running containers.
We are dropping support for Rails 5 in our integration tests.
mec
force-pushed
the
chore/drop-ruby-2-and-rails-5-int-testing
branch
from
10f676e
to
0f1f10d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting these is more effort than value so we will drop support.
This work only relates to our integration tests and not the gem itself.