-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some actions body to AsanaHelper + use ERB for processing templates #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
force-pushed
the
dominik/asana-extract-task-id-helper
branch
from
September 14, 2024 10:34
39301d9
to
df62b1d
Compare
…ing ERB templates
ayoy
changed the title
Move asana_extract_task_id action body to a helper function
Move some actions body to AsanaHelper + use ERB for processing templates
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
as functions: extract_asana_task_id, extract_asana_task_assignee,
get_release_automation_subtask_id, get_asana_user_id_for_github_handle,
upload_file_to_asana_task. Actions only call their respective helper method.
This is to simplify using these functionalities from other actions (better not
call action from action, but rather use helpers for common functionality).
now use ERB for processing templates. They take
template_args
Hash argumentthat provides template variables. For backward compatibility, environment variables
are currently merged to template_args (with their keys lowercased), so that call
sites in GHA workflows don't have to be updated. Future workflows implemented in
fastlane will be able to use template_args with lowercased parameter names and
eventually we'll remove the environment workaround.