Add tests for processing all templates for create_action_item

duckduckgo · Sep 14, 2024 · 39301d9 · 39301d9
1 parent 992b00c
commit 39301d9
Show file tree

Hide file tree

Showing 21 changed files with 410 additions and 42 deletions.
diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
@@ -31,16 +31,19 @@ def self.run(params)
           text = "#{comment}\n\nWorkflow URL: #{workflow_url}"
           create_story(asana_access_token, task_id, text: text)
         else
-          template_file = Helper::DdgAppleAutomationHelper.path_for_asset_file("asana_add_comment/templates/#{template_name}.html.erb")
-          template_content = Helper::DdgAppleAutomationHelper.load_file(template_file)
-          return unless template_content
+          html_text = process_template(template_name, args)
+          sanitized_html_text = Helper::DdgAppleAutomationHelper.sanitize_asana_html_notes(html_text)
+          create_story(asana_access_token, task_id, html_text: sanitized_html_text)
+        end
+      end
 
-          erb_template = ERB.new(template_content)
-          html_text = erb_template.result(binding)
+      def self.process_template(template_name, args)
+        template_file = Helper::DdgAppleAutomationHelper.path_for_asset_file("asana_add_comment/templates/#{template_name}.html.erb")
+        template_content = Helper::DdgAppleAutomationHelper.load_file(template_file)
+        return unless template_content
 
-          html_text = Helper::DdgAppleAutomationHelper.sanitize_asana_html_notes(html_text)
-          create_story(asana_access_token, task_id, html_text: html_text)
-        end
+        erb_template = ERB.new(template_content)
+        erb_template.result(binding)
       end
 
       def self.description

diff --git a/...n/ddg_apple_automation/assets/asana_add_comment/templates/debug-symbols-uploaded.html.erb b/...n/ddg_apple_automation/assets/asana_add_comment/templates/debug-symbols-uploaded.html.erb
@@ -1,5 +1,5 @@
 <body>
   🐛 Debug symbols archive for <%= args['tag'] %> build is uploaded to <code><%= args['dsym_s3_path'] %></code>.<br>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['workflow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...lane/plugin/ddg_apple_automation/assets/asana_add_comment/templates/dmg-uploaded.html.erb b/...lane/plugin/ddg_apple_automation/assets/asana_add_comment/templates/dmg-uploaded.html.erb
@@ -1,5 +1,5 @@
 <body>
   📥 DMG for <%= args['tag'] %> is available from <a href='<%= args['dmg_url'] %>'><%= args['dmg_url'] %></a>.<br>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...ugin/ddg_apple_automation/assets/asana_add_comment/templates/hotfix-branch-ready.html.erb b/...ugin/ddg_apple_automation/assets/asana_add_comment/templates/hotfix-branch-ready.html.erb
@@ -5,5 +5,5 @@
     <li>Point any pull requests with changes required for the hotfix release to that branch.</li>
   </ul>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...utomation/assets/asana_add_comment/templates/internal-release-ready-merge-failed.html.erb b/...utomation/assets/asana_add_comment/templates/internal-release-ready-merge-failed.html.erb
@@ -12,5 +12,5 @@
     </li>
   </ul>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/..._automation/assets/asana_add_comment/templates/internal-release-ready-tag-failed.html.erb b/..._automation/assets/asana_add_comment/templates/internal-release-ready-tag-failed.html.erb
@@ -9,5 +9,5 @@
   <a data-asana-gid='<%= args['assignee_id'] %>' />, please proceed with manual tagging and merging <a data-asana-gid='<%= args['task_id'] %>'
     data-asana-dynamic='false'>according to instructions</a>.<br>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...n/ddg_apple_automation/assets/asana_add_comment/templates/internal-release-ready.html.erb b/...n/ddg_apple_automation/assets/asana_add_comment/templates/internal-release-ready.html.erb
@@ -12,5 +12,5 @@
     <li>🔱 <code><%= args['branch'] %></code> branch has been successfully merged to <code><%= args['base_branch'] %></code>.</li>
   </ul>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...dg_apple_automation/assets/asana_add_comment/templates/public-release-tag-failed.html.erb b/...dg_apple_automation/assets/asana_add_comment/templates/public-release-tag-failed.html.erb
@@ -9,5 +9,5 @@
   <a data-asana-gid='<%= args['assignee_id'] %>' />, please proceed with the release <a data-asana-gid='<%= args['task_id'] %>'
     data-asana-dynamic='false'>according to instructions</a>.<br>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...on/assets/asana_add_comment/templates/public-release-tagged-delete-branch-failed.html.erb b/...on/assets/asana_add_comment/templates/public-release-tagged-delete-branch-failed.html.erb
@@ -11,5 +11,5 @@
     </li>
   </ul>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...in/ddg_apple_automation/assets/asana_add_comment/templates/public-release-tagged.html.erb b/...in/ddg_apple_automation/assets/asana_add_comment/templates/public-release-tagged.html.erb
@@ -8,5 +8,5 @@
     <li>🚀 The relase will be published to Sparkle in a few minutes (you'll get notified).</li>
   </ul>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/...utomation/assets/asana_add_comment/templates/validate-check-for-updates-internal.html.erb b/...utomation/assets/asana_add_comment/templates/validate-check-for-updates-internal.html.erb
@@ -6,5 +6,5 @@
         data-asana-gid='<%= args['task_id'] %>' /> which concludes the internal release process.</li>
   </ul>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/..._automation/assets/asana_add_comment/templates/validate-check-for-updates-public.html.erb b/..._automation/assets/asana_add_comment/templates/validate-check-for-updates-public.html.erb
@@ -7,5 +7,5 @@
       process.</li>
   </ul>
   <br>
-  🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+  🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
 </body>
diff --git a/..._apple_automation/assets/asana_create_action_item/templates/appcast-failed-hotfix.yml.erb b/..._apple_automation/assets/asana_create_action_item/templates/appcast-failed-hotfix.yml.erb
@@ -28,6 +28,6 @@ html_notes: |
       <li>Verify that you're being offered to update to <%= args['tag'] %>.</li>
       <li>Verify that the update works.</li>
     </ol><br>
-    🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+    🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
   </body>
 
diff --git a/...pple_automation/assets/asana_create_action_item/templates/appcast-failed-internal.yml.erb b/...pple_automation/assets/asana_create_action_item/templates/appcast-failed-internal.yml.erb
@@ -29,6 +29,6 @@ html_notes: |
       <li>Verify that you're being offered to update to <%= args['tag'] %>.</li>
       <li>Verify that the update works.</li>
     </ol><br>
-    🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+    🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
   </body>
 
diff --git a/..._apple_automation/assets/asana_create_action_item/templates/appcast-failed-public.yml.erb b/..._apple_automation/assets/asana_create_action_item/templates/appcast-failed-public.yml.erb
@@ -28,5 +28,5 @@ html_notes: |
       <li>Verify that you're being offered to update to <%= args['tag'] %>.</li>
       <li>Verify that the update works.</li>
     </ol><br>
-    🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+    🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
   </body>
diff --git a/...g_apple_automation/assets/asana_create_action_item/templates/delete-branch-failed.yml.erb b/...g_apple_automation/assets/asana_create_action_item/templates/delete-branch-failed.yml.erb
@@ -8,5 +8,5 @@ html_notes: |
     </ul>
     Complete this task when ready, or if the release branch has already been deleted.<br>
     <br>
-    🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+    🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
   </body>
diff --git a/..._automation/assets/asana_create_action_item/templates/internal-release-tag-failed.yml.erb b/..._automation/assets/asana_create_action_item/templates/internal-release-tag-failed.yml.erb
@@ -35,5 +35,5 @@ html_notes: |
     Complete this task when ready and proceed with testing the build. If you're bumping an internal release, you should get another task asking you to publish the release in Sparkle. 
     Look for other tasks in <a data-asana-gid='<%= args['automation_task_id'] %>'/> task and handle them as needed.<br>
     <br>
-    🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+    🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
   </body>
diff --git a/...lugin/ddg_apple_automation/assets/asana_create_action_item/templates/merge-failed.yml.erb b/...lugin/ddg_apple_automation/assets/asana_create_action_item/templates/merge-failed.yml.erb
@@ -24,5 +24,5 @@ html_notes: |
     </ul>
     Complete this task when ready and proceed with testing the build.<br>
     <br>
-    🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+    🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
   </body>
diff --git a/...le_automation/assets/asana_create_action_item/templates/public-release-tag-failed.yml.erb b/...le_automation/assets/asana_create_action_item/templates/public-release-tag-failed.yml.erb
@@ -27,5 +27,5 @@ html_notes: |
     </ul><br>
     Complete this task when ready.<br>
     <br>
-    🔗 Workflow URL: <a href='<%= args['worklow_url'] %>'><%= args['worklow_url'] %></a>.
+    🔗 Workflow URL: <a href='<%= args['workflow_url'] %>'><%= args['workflow_url'] %></a>.
   </body>