Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getInterestGroupAdAuctionData removal #1165

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add getInterestGroupAdAuctionData removal #1165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef1061
Add getInterestGroupAdAuctionData removal
jonathanKingston Oct 25, 2024
74c632f
Update google-rejected.js
jonathanKingston Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions injected/src/features/google-rejected.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ export default class GoogleRejected extends ContentFeature {
if ('adAuctionComponents' in Navigator.prototype) {
delete Navigator.prototype.adAuctionComponents
}
// https://github.com/WICG/privacy-preserving-ads/blob/main/API%20Details.md
if (this.getFeatureSetting('getInterestGroupAdAuctionData')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put it behind additional flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good practice really. In case we want to enable the API on a particular website, additionally there's higher risk as we've not seen it in the wild yet.

if ('getInterestGroupAdAuctionData' in Navigator.prototype) {
delete Navigator.prototype.getInterestGroupAdAuctionData
}
}
} catch {
// Throw away this exception, it's likely a confict with another extension
}
Expand Down
Loading