Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getInterestGroupAdAuctionData removal #1165

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Oct 25, 2024

Asana Task/Github Issue: https://app.asana.com/0/1208598406046969/1208627396785444/f

Description

Conditionally removes the getInterestGroupAdAuctionData API as specified here: https://github.com/WICG/privacy-preserving-ads/blob/main/API%20Details.md

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 74c632f
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/671b90d43f08cc000862562c
😎 Deploy Preview https://deploy-preview-1165--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathanKingston jonathanKingston marked this pull request as draft October 25, 2024 12:35
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

[Beta] Generated file diff

Time updated: Fri, 25 Oct 2024 12:37:30 GMT

Android
    - android/contentScope.js

File has changed

Chrome
    - chrome/inject.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js

File has changed

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API has not really shipped yet (AFIAK - tested in 132.0.6797.0 ), so we are adding it early, right? I can see it in chromium's source code, so I guess it's coming.

@@ -21,6 +21,12 @@ export default class GoogleRejected extends ContentFeature {
if ('adAuctionComponents' in Navigator.prototype) {
delete Navigator.prototype.adAuctionComponents
}
// https://github.com/WICG/privacy-preserving-ads/blob/main/API%20Details.md
if (this.getFeatureSetting('getInterestGroupAdAuctionData')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put it behind additional flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good practice really. In case we want to enable the API on a particular website, additionally there's higher risk as we've not seen it in the wild yet.

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (that said, I wasn't able to fully test it because I'm not sure how to enable this API even via chrome://flags).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants