-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getInterestGroupAdAuctionData removal #1165
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 25 Oct 2024 12:37:30 GMT Android
File has changed Chrome
File has changed Chrome-mv3
File has changed Firefox
File has changed Integration
File has changed Windows
File has changed Apple
File has changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API has not really shipped yet (AFIAK - tested in 132.0.6797.0 ), so we are adding it early, right? I can see it in chromium's source code, so I guess it's coming.
@@ -21,6 +21,12 @@ export default class GoogleRejected extends ContentFeature { | |||
if ('adAuctionComponents' in Navigator.prototype) { | |||
delete Navigator.prototype.adAuctionComponents | |||
} | |||
// https://github.com/WICG/privacy-preserving-ads/blob/main/API%20Details.md | |||
if (this.getFeatureSetting('getInterestGroupAdAuctionData')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why put it behind additional flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good practice really. In case we want to enable the API on a particular website, additionally there's higher risk as we've not seen it in the wild yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (that said, I wasn't able to fully test it because I'm not sure how to enable this API even via chrome://flags).
Asana Task/Github Issue: https://app.asana.com/0/1208598406046969/1208627396785444/f
Description
Conditionally removes the
getInterestGroupAdAuctionData
API as specified here: https://github.com/WICG/privacy-preserving-ads/blob/main/API%20Details.mdTesting Steps
Checklist
Please tick all that apply: