-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize the text in the common target #10388
Draft
JaynieBai
wants to merge
9
commits into
dotnet:main
Choose a base branch
from
JaynieBai:jennybai/issue#10171
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4bebe67
Localize the text in the common target
JaynieBai 1bdbe16
Merge branch 'main' of https://github.com/dotnet/msbuild into jennyba…
JaynieBai 273d6fb
Merge branch 'main' of https://github.com/dotnet/msbuild into jennyba…
JaynieBai ba98677
Add missing resource name
JaynieBai c6fd669
Refactor the code
JaynieBai d8a3244
Fix the typo error
JaynieBai 2ef73ef
Fix typo error
JaynieBai 2908899
Fix wrong words
JaynieBai 0dacce6
Add deleted line
JaynieBai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3051,6 +3051,58 @@ | |||||
<comment>{StrBegin="MSB9904: "}</comment> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.BaseIntermediateOutputPathMismatchWarning"> | ||||||
<value>MSB3539: The value of the property "BaseIntermediateOutputPath" was modified after it was used by MSBuild which can lead to unexpected build results. Tools such as NuGet will write outputs to the path specified by the "MSBuildProjectExtensionsPath" instead. To set this property, you must do so before Microsoft.Common.props is imported, for example by using Directory.Build.props. For more information, please visit https://go.microsoft.com/fwlink/?linkid=869650"</value> | ||||||
<comment>{StrBegin="MSB3539: "} </comment> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.MSBuildProjectExtensionsPathModifiedAfterUse"> | ||||||
<value>MSB3540: The value of the property "MSBuildProjectExtensionsPath" was modified after it was used by MSBuild which can lead to unexpected build results. To set this property, you must do so before Microsoft.Common.props is imported, for example by using Directory.Build.props. For more information, please visit https://go.microsoft.com/fwlink/?linkid=869650</value> | ||||||
<comment>{StrBegin="MSB3540: "}</comment> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.InvalidConfigurationTextWithBuildingInsideVisualStudio"> | ||||||
<value>The BaseOutputPath/OutputPath property is not set for project '{0}'. Please check to make sure that you have specified a valid combination of Configuration and Platform for this project. Configuration='{1}' Platform='{2}'. This error may also appear if some other project is trying to follow a project-to-project reference to this project, this project has been unloaded or is not included in the solution, and the referencing project does not build using the same or an equivalent Configuration or Platform.</value> | ||||||
<comment>LOCALIZATION: Do not localize the words "BaseOutputPath/OutputPath", "Configuration" and "Platform"</comment> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.InvalidConfigurationTextWithoutBuildingInsideVisualStudio"> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
<value>The BaseOutputPath/OutputPath property is not set for project '{0}'. Please check to make sure that you have specified a valid combination of Configuration and Platform for this project. Configuration='{1}' Platform='{2}'. You may be seeing this message because you are trying to build a project without a solution file, and have specified a non-default Configuration or Platform that doesn't exist for this project.</value> | ||||||
<comment>LOCALIZATION: Do not localize the words "BaseOutputPath/OutputPath", "Configuration" and "Platform"</comment> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.ManifestResourceWithNoCultureWarning"> | ||||||
<value>{0}: {1} item type is deprecated. Emit EmbeddedResource items instead, with metadata WithCulture='{2}', Type='{3}', and optional LogicalName.</value> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.PropertyWithTrailingSlash"> | ||||||
<value>The {0} must end with a trailing slash.</value> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.DeploymentUnpublishable"> | ||||||
<value>Skipping unpublishable project.</value> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.GenerateManifestsOnlyForExe"> | ||||||
<value>Publish is only valid for 'Windows Application' or 'Console Application' project types.</value> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.SigningKeyRequired"> | ||||||
<value>A signing key is required in order to publish this project. Please specify a ManifestKeyFile or ManifestCertificateThumbprint value. Publishing from Visual Studio will automatically configure a signing key for this project.</value> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.RunTargetDependsOnMessage"> | ||||||
<value>Cannot run '{0}' because project output type is not '.exe'</value> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.CrossTargetingGetTargetFrameworks"> | ||||||
<value>Internal MSBuild error: Non-CrossTargeting GetTargetFrameworks target should not be used in cross targeting (outer) build</value> | ||||||
</data> | ||||||
|
||||||
<data name="CommonTarget.SplitResourcesByCultureEmbeddedResourceMessage"> | ||||||
<value>{0}: {1} item type is deprecated. Use EmbeddedResource items instead.</value> | ||||||
</data> | ||||||
|
||||||
<!-- | ||||||
The tasks message bucket is: MSB3001 - MSB3999 | ||||||
|
||||||
|
@@ -3142,7 +3194,7 @@ | |||||
|
||||||
MSB4000 - MSB4200 Portable targets & tasks (vsproject\flavors\portable\msbuild) | ||||||
MSB9000 - MSB9900 MSBuild targets files (C++) | ||||||
|
||||||
MSB9901 - MSB9990 MSBuild common targets messages | ||||||
|
||||||
The following codes are not longer used but have shipped so should not be reused: | ||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.