Localize the text in the common target

[JaynieBai]

Fixes #10171

Context

MsBuild produces unlocalized messages for some specific validation cases that happen in scope of target.
The example of the task usage: https://github.com/YuliiaKovalova/msbuild/blob/be21253d85f7766356880d376e26aaa69c34c4cd/src/Tasks/Microsoft.Common.CurrentVersion.targets#L862

Changes Made

Refactor the existing messages with the recently added task allows to produce localized messages:
https://github.com/dotnet/msbuild/blob/79dff86b18613cfe3510b719ac28e8a8c3e7f96c/src/Tasks/MSBuildInternalMessage.cs , produced by with hardcoded text.

Testing

Notes

[JanKrivanek]

Looks good.

Though - I was not controllig in detail 1:1 equality of the literals in .targets with the new in resx files - I suppose they were copied over (with just applying format parameters)

[Nirmal4G]

Why not use CommonSdk instead of CommonTarget? It could be useful if you decide to do #1686?

Also, Message Code (like MSB3539) should be separately specified to ensure searchability in these files.

[Nirmal4G]

Suggested change

	<MSBuildInternalMessage Condition=" '$(_InvalidConfigurationError)' == 'true' and '$(BuildingInsideVisualStudio)' == 'true'" ResourceName="CommonTarget.InvalidConfigurationTextWithBuildingInsideVisualStudio" Severity="Error" FormatArguments="$(MSBuildProjectFile);$(_OriginalConfiguration);$(_OriginalPlatform)"/>
	<MSBuildInternalMessage Condition=" '$(_InvalidConfigurationError)' == 'true' and '$(BuildingInsideVisualStudio)' != 'true'" ResourceName="CommonTarget.InvalidConfigurationTextWithoutBuildingInsideVisualStudio" Severity="Error" FormatArguments="$(MSBuildProjectFile);$(_OriginalConfiguration);$(_OriginalPlatform)"/>
	<MSBuildInternalMessage Condition=" '$(_InvalidConfigurationWarning)' == 'true' and '$(BuildingInsideVisualStudio)' == 'true'" ResourceName="CommonTarget.InvalidConfigurationTextWithBuildingInsideVisualStudio" Severity="Warning" FormatArguments="$(MSBuildProjectFile);$(_OriginalConfiguration);$(_OriginalPlatform)"/>
	<MSBuildInternalMessage Condition=" '$(_InvalidConfigurationWarning)' == 'true' and '$(BuildingInsideVisualStudio)' != 'true'" ResourceName="CommonTarget.InvalidConfigurationTextWithoutBuildingInsideVisualStudio" Severity="Warning" FormatArguments="$(MSBuildProjectFile);$(_OriginalConfiguration);$(_OriginalPlatform)"/>
	<PropertyGroup>
	<_InvalidConfigurationMessageResourceName Condition=" '$(BuildingInsideVisualStudio)' == 'true' ">CommonSdk.InvalidConfigurationTextWhenBuildingInsideVisualStudio</_InvalidConfigurationMessageResourceName>
	<_InvalidConfigurationMessageResourceName Condition=" '$(BuildingInsideVisualStudio)' != 'true' ">CommonSdk.InvalidConfigurationTextWhenBuildingOutsideVisualStudio</_InvalidConfigurationMessageResourceName>
	</PropertyGroup>
	<MSBuildInternalMessage Code="MSB3541"
	ResourceName="$(_InvalidConfigurationMessageResourceName)"
	Severity="$(_InvalidConfigurationMessageSeverity)"
	FormatArguments="$(MSBuildProjectFile);$(_OriginalConfiguration);$(_OriginalPlatform)"
	Condition="'$(_InvalidConfigurationMessageSeverity)' != ''" />
	<PropertyGroup>
	<_InvalidConfigurationMessageSeverity />
	<_InvalidConfigurationMessageResourceName />
	</PropertyGroup>

Linked Changes

If you are applying this patch, replace the _InvalidConfiguration[Warning|Error] prperties with _InvalidConfigurationMessageSeverity like so:

Replace these lines

msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets

Lines 205 to 206 in 47f364c

	<_InvalidConfigurationError Condition=" '$(SkipInvalidConfigurations)' != 'true' ">true</_InvalidConfigurationError>
	<_InvalidConfigurationWarning Condition=" '$(SkipInvalidConfigurations)' == 'true' ">true</_InvalidConfigurationWarning>

with these lines

      <_InvalidConfigurationMessageSeverity Condition=" '$(SkipInvalidConfigurations)' == 'true' ">Warning</_InvalidConfigurationMessageSeverity>
      <_InvalidConfigurationMessageSeverity Condition=" '$(SkipInvalidConfigurations)' != 'true' ">Error</_InvalidConfigurationMessageSeverity>

Important

You could use the above pattern everywhere else. It makes the code easy to read. I don't know if cleaning up the properties is needed or not but kept there for clarity.

[Nirmal4G]

Suggested change

	<data name="CommonTarget.InvalidConfigurationTextWithBuildingInsideVisualStudio">
	<data name="CommonSdk.InvalidConfigurationTextWhenBuildingInsideVisualStudio">

[Nirmal4G]

Suggested change

	<data name="CommonTarget.InvalidConfigurationTextWithoutBuildingInsideVisualStudio">
	<data name="CommonSdk.InvalidConfigurationTextWhenBuildingOutsideVisualStudio">

[Nirmal4G]

nit: undo the line deletion!

[Nirmal4G]

Sorry about my mistake.

Suggested change

	<MSBuildInternalMessage ResourceName="$(_InvalidConfigurationMessageResourceName)" Severity="$(_InvalidConfigurationMessageSeverity)" FormatArguments="$(MSBuildProjectFile);$(_OriginalConfiguration);$(_OriginalPlatform)"/>
	<MSBuildInternalMessage
	ResourceName="$(_InvalidConfigurationMessageResourceName)"
	Severity="$(_InvalidConfigurationMessageSeverity)"
	FormatArguments="$(MSBuildProjectFile);$(_OriginalConfiguration);$(_OriginalPlatform)"
	Condition="'$(_InvalidConfigurationMessageSeverity)' != ''" />

Important

For the condition, we could have used the same output path check here also
but we must not forget to update both when it changes in the future.
That's why I have used Severity instead.

[JaynieBai]

Thanks a lot @Nirmal4G

[Nirmal4G]

Suggested change

	Severity="$(_NonExistentProjectReferenceSecuity)"
	Severity="$(_NonExistentProjectReferenceSeverity)"