feat(announcements): modal closing enhancement for announcements #27707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested changes
Feb 23, 2024
...ents/dot-toolbar/components/dot-toolbar-notifications/dot-toolbar-notifications.component.ts
Outdated
Show resolved
Hide resolved
.../app/view/components/dot-toolbar/components/dot-toolbar-user/dot-toolbar-user.component.scss
Outdated
Show resolved
Hide resolved
.../app/view/components/dot-toolbar/components/dot-toolbar-user/dot-toolbar-user.component.scss
Show resolved
Hide resolved
...p/view/components/dot-toolbar/components/dot-toolbar-user/dot-toolbar-user.component.spec.ts
Outdated
Show resolved
Hide resolved
...rc/app/view/components/dot-toolbar/components/dot-toolbar-user/dot-toolbar-user.component.ts
Outdated
Show resolved
Hide resolved
manuelrojas
requested review from
rjvelazco,
fmontes,
KevinDavilaDotCMS,
hmoreras and
oidacra
rjvelazco
requested changes
Feb 23, 2024
...dotcms-ui/src/app/view/components/_common/dot-dropdown-component/dot-dropdown.component.html
Outdated
Show resolved
Hide resolved
...ents/dot-toolbar/components/dot-toolbar-announcements/dot-toolbar-announcements.component.ts
Outdated
Show resolved
Hide resolved
...rc/app/view/components/dot-toolbar/components/dot-toolbar-user/dot-toolbar-user.component.ts
Outdated
Show resolved
Hide resolved
...ts/dot-toolbar/components/dot-toolbar-announcements/dot-toolbar-announcements.component.html
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Feb 23, 2024
rjvelazco
approved these changes
Feb 23, 2024
|
This was
linked to
issues
Feb 23, 2024
manuelrojas
deleted the
issue-27434-modal-closing-enhancement-for-announcements
branch
spbolton
pushed a commit
to spbolton/core
that referenced
this pull request
Feb 28, 2024
…CMS#27707) * dotCMS#27434 Adding modal closing enhancement * dotCMS#27434 Adding modal closing enhancement * Clean up * Clean up * Applying style * PR Feedback * PR feedback * dotCMS#27434 Adding toolbar * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots
Screen.Recording.2024-02-23.at.11.51.33.mov