Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Closing Enhancement for Announcements #27434

Closed
bryanboza opened this issue Jan 25, 2024 · 3 comments · Fixed by #27707
Closed

Modal Closing Enhancement for Announcements #27434

bryanboza opened this issue Jan 25, 2024 · 3 comments · Fixed by #27707
Labels
Merged QA : Approved QA : Passed Internal Release : 24.03.1 Announcements Team : Scout Type : Defect

Comments

@bryanboza
Copy link
Member

bryanboza commented Jan 25, 2024 •
edited
Loading

Problem Statement

In dotCMS, there is an issue where the announcements window does not automatically close when users click outside the modal. This behavior deviates from standard modal interactions and can cause inconvenience for users who expect the modal to close when clicking outside its boundaries.

Steps to Reproduce

  • Log into the dotCMS backend with the necessary credentials.
  • Access the announcements window or modal.
  • Click outside the modal, attempting to close it.
  • Observe that the modal does not close, and users need to click again in the announcements logo to dismiss the window.

Acceptance Criteria

Modal Closing on External Click: Implement functionality that allows users to close the announcements window by clicking outside the modal.
User-Friendly Interaction: Ensure that the modal closure occurs seamlessly, providing a user-friendly experience.

dotCMS Version

Tested on master // Docker // FF

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important
@nollymar nollymar moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Feb 12, 2024
@damen-dotcms
Copy link
Contributor

damen-dotcms commented Feb 12, 2024 •
edited
Loading

Fixing this will bring the Announcement Menu in-line with the prototype.

@nollymar nollymar moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Feb 13, 2024
@nollymar nollymar removed the Triage label Feb 13, 2024
@manuelrojas manuelrojas moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Feb 15, 2024
@manuelrojas manuelrojas self-assigned this Feb 15, 2024
manuelrojas added a commit that referenced this issue Feb 23, 2024
@manuelrojas
#27434 Adding modal closing enhancement
8f8b9d6
manuelrojas added a commit that referenced this issue Feb 23, 2024
@manuelrojas
#27434 Adding modal closing enhancement
0d2cf55
manuelrojas added a commit that referenced this issue Feb 23, 2024
@manuelrojas
#27434 Adding toolbar
017684d
@manuelrojas manuelrojas moved this from In Progress to In Review in dotCMS - Product Planning Feb 23, 2024
@manuelrojas manuelrojas linked a pull request Feb 23, 2024 that will close this issue
feat(announcements): modal closing enhancement for announcements #27707
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 23, 2024
@manuelrojas
feat(announcements): modal closing enhancement for announcements (#27707
892cb3c 
)

* #27434 Adding modal closing enhancement

* #27434 Adding modal closing enhancement

* Clean up

* Clean up

* Applying style

* PR Feedback

* PR feedback

* #27434 Adding toolbar

* PR feedback
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Feb 23, 2024
@nollymar nollymar reopened this Feb 26, 2024
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Feb 26, 2024
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Feb 26, 2024
@dcolina dcolina self-assigned this Feb 26, 2024
@dcolina
Copy link
Contributor

dcolina commented Feb 26, 2024

Internal QA: PASSED.

As we can see in the following video, the functionally works as expected it.

Screen.Recording.2024-02-26.at.18.35.21.mov

@dcolina dcolina removed their assignment Feb 26, 2024
@dcolina dcolina moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Feb 26, 2024
@github-project-automation github-project-automation bot moved this from QA - Backlog to Done in dotCMS - Product Planning Feb 27, 2024
@nollymar nollymar moved this to QA - Backlog in dotCMS - Product Planning Feb 27, 2024
spbolton pushed a commit to spbolton/core that referenced this issue Feb 28, 2024
@manuelrojas @spbolton
feat(announcements): modal closing enhancement for announcements (dot…
dcbdf1b 
…CMS#27707)

* dotCMS#27434 Adding modal closing enhancement

* dotCMS#27434 Adding modal closing enhancement

* Clean up

* Clean up

* Applying style

* PR Feedback

* PR feedback

* dotCMS#27434 Adding toolbar

* PR feedback
@bryanboza
Copy link
Member Author

Fixed, tested on master // Docker // FF

@bryanboza bryanboza moved this from QA - Backlog to Done in dotCMS - Product Planning Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged QA : Approved QA : Passed Internal Release : 24.03.1 Announcements Team : Scout Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(announcements): modal closing enhancement for announcements dotCMS/core
5 participants
@bryanboza @manuelrojas @nollymar @dcolina @damen-dotcms