wallet: clear memory leaks from radio doge functions #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanimo
force-pushed
the
0.1.3-dev-fix-spvtest
branch
3 times, most recently
from
63095d8
to
875b678
Compare
edtubbs
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
ACK, reviewed and tested updates with #187 on x86_64 with linux; verified no memory leaks during the scrape test or address registration/unregistration and docker rpctest ran successfully.
ed@ed-VirtualBox:~/dogecoin/foundation/libdogecoin$ docker run -it --rm xanimo/rpctest cat dummy
File '/home/root/regtest_wallet.db' copied to 'tmp.bin'
address: mggFqzCUQmWWnh9vaoyT4BwKen7EbqhBmY
registered: 1 mggFqzCUQmWWnh9vaoyT4BwKen7EbqhBmY
total: 6.00000000
utxo count: 4
txid: 6a9cfcd9440a2592bc6e3c22a1e3f652faa2e32318cde5b3cf487021fdbeec3d
vout: 0
amount: 1.50000000
txid: a6df1d393d9e9d72b368688e95ed1b36befafd449e1648ef7dcd18755b77a2a7
vout: 0
amount: 1.50000000
txid: cc53c8a3af59af47c9bdf06f77c4d80c07b86eb311775040e131f4c183d0fe13
vout: 0
amount: 1.50000000
txid: 4beb4ece61a51608dd6fe7bcbe3519106234e8c6fd40a597d8d4dc3ab862b214
vout: 1
amount: 1.50000000
File '/home/root/temp.bin' renamed to '/home/root/regtest_wallet.db' for mggFqzCUQmWWnh9vaoyT4BwKen7EbqhBmY
unregistered: true
File 'tmp.bin' copied to '/home/root/regtest_wallet.db'
ed@ed-VirtualBox:~/dogecoin/foundation/libdogecoin$
875b678
to
dc42dc0
Compare
-total redesign of dogecoin_unregister_watch_address_with_node to alleviate calls to concat -populate wallet->filename on dogecoin_wallet_new otherwise it's populated by name and freed -added replace_last_after_delim which searchs for a match and replaces with replacement -added remove_substr which returns a string with substr removed -changed wallet cmd to sanity -sanity cmd test now iterates through multiple addresses -free waddr and buf and call dogecoin_wallet_next_addr on edge case where we delete our last address -refactor/fix spvtool.py, fetch.py, .gitignore dummy -clear spvnode wallet sanity cmd of memleaks -fix wallet sanity check on windows -added file_copy function to utils -check if file exists before performance of file operations -free remaining waddr during sanity check -run wallet sanity check in spvtool.py test and verify wallet balance -run spvtool.py only on returncode match from previous subprocess completion -add Dockerfile for easier implementation -add to x86_64-linux-dbg in ci.yml -adapt to use -l for zero prompts during automated testing
xanimo
force-pushed
the
0.1.3-dev-fix-spvtest
branch
from
dc42dc0
to
64b78d2
Compare
|
here we go. Notating this in radiodoge issue #3 dogecoinfoundation/radiodoge#3 for later reference. |
This was referenced Jan 23, 2024
|
crossreferences TODO: radiodoge retrofit Relevant: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-total redesign of dogecoin_unregister_watch_address_with_node to alleviate calls to concat
-populate wallet->filename on dogecoin_wallet_new otherwise it's populated by name and freed
-added replace_last_after_delim which searchs for a match and replaces with replacement
-added remove_substr which returns a string with substr removed
-changed wallet cmd to sanity
-sanity cmd test now iterates through multiple addresses
-free waddr and buf and call dogecoin_wallet_next_addr on edge case where we delete our last address
-refactor/fix spvtool.py, fetch.py, .gitignore dummy
-clear spvnode wallet sanity cmd of memleaks
-fix wallet sanity check on windows
-added file_copy function to utils
-check if file exists before performance of file operations
-free remaining waddr during sanity check
-run wallet sanity check in spvtool.py test and verify wallet balance
-run spvtool.py only on returncode match from previous subprocess completion