Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: redesign utxo and radio doge functions #180

Merged
merged 1 commit into from
Jan 23, 2024
Merged

wallet: redesign utxo and radio doge functions #180

merged 1 commit into from
Jan 23, 2024

Conversation

xanimo
Copy link
Member

@xanimo xanimo commented Dec 22, 2023

No description provided.

@xanimo xanimo changed the title wallet: redesign utxo and radio doge function design wallet: redesign utxo and radio doge functions Dec 22, 2023
@xanimo xanimo force-pushed the 0.1.3-dev-utxo-uthash branch 5 times, most recently from 398621b to b4c6d71 Compare December 22, 2023 23:39
edtubbs
edtubbs approved these changes Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@edtubbs edtubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, reviewed and tested updates on x86_64; verified no memory leaks during the scrape test or address registration/unregistration.

michilumin
michilumin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just making a note here with keywords to retrofit last version of radio doge. Changes should be minor to interface (and work better not using vectors, structs instead).

@michilumin michilumin merged commit e4ea836 into dogecoinfoundation:0.1.3-dev Jan 23, 2024
8 checks passed
@michilumin michilumin mentioned this pull request Jan 23, 2024
Open
@michilumin
Copy link
Contributor

crossreferences

TODO: radiodoge retrofit
dogecoinfoundation/radiodoge#3

Relevant:
#188

@michilumin michilumin mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edtubbs edtubbs edtubbs approved these changes

@michilumin michilumin michilumin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xanimo @michilumin @edtubbs