WIP: rewrite runAttach to be exported #4643
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Nov 7, 2023
cli/command/container/attach.go
Outdated
| Stderr: true, | ||
| DetachKeys: detachKeys, | ||
| if opts.DetachKeys == "" { | ||
| opts.DetachKeys = dockerCli.ConfigFile().DetachKeys |
There was a problem hiding this comment.
Ideally, we'd move this elsewhere so that this function can potentially only depend on the API-client, not the CLI 🤔
thaJeztah
force-pushed
the
attach_pass_container_arg
branch
from
9429e6f
to
edc58e3
Compare
thaJeztah
force-pushed
the
attach_pass_container_arg
branch
from
edc58e3
to
af78247
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4643 +/- ##
=======================================
Coverage 59.58% 59.59%
=======================================
Files 287 285 -2
Lines 24722 24730 +8
=======================================
+ Hits 14731 14737 +6
Misses 9106 9106
- Partials 885 887 +2 |
thaJeztah
force-pushed
the
attach_pass_container_arg
branch
2 times, most recently
from
0000946
to
d92821d
Compare
Trying to make "runAttach" not depend on attachOptions, and to see if we can make it accept container.AttachOptions instead relates to docker#4637 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
attach_pass_container_arg
branch
from
d92821d
to
3498ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)