cli/command/container: minor cleanup in attach #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename confusing `target` argument, and use `containerID` in all places; also make the variable more clearly local-scoped. - rename `dockerCli` to be correctly camel-case, and to be consistent in all places in this file. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4832 +/- ##
==========================================
- Coverage 59.58% 59.58% -0.01%
==========================================
Files 287 287
Lines 24722 24721 -1
==========================================
- Hits 14731 14730 -1
Misses 9106 9106
Partials 885 885 |
vvoland
approved these changes
Jan 26, 2024
sam-thibault
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetargument, and usecontainerIDin all places; also make the variable more clearly local-scoped.dockerClito be correctly camel-case, and to be consistent in all places in this file.- A picture of a cute animal (not mandatory but encouraged)