TreeView: Use initialOptions prop to save view state
#1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is saved along with the Lumino layout for restoring after navigation. Implemented for the log view only so far. Log view: don't query files in job log mode when no ID given use initial options prop to save view state removed views/initialOptions.js removed views/initialOptions.spec added e2e test review amends updated mailmap
markgrahamdawson
changed the title
initialOptions prop to save view stateinitialOptions prop to save view state
MetRonnie
reviewed
Mar 12, 2024
MetRonnie
approved these changes
Mar 12, 2024
8 tasks
oliver-sanders
approved these changes
Mar 19, 2024
8 tasks
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes build on the work undertaken to save & restore workspace layout on navigation #1664
Which is part of a larger issue #662
There is an equivalent pull request for the logview #1688
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.