Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gantt view: use initialOptions to save & restore view state on navigation #1745

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

markgrahamdawson
Copy link
Contributor

@markgrahamdawson markgrahamdawson commented Apr 9, 2024

These changes build on the work undertaken to save & restore workspace layout on navigation #1664

Which is part of a larger issue #662

There was an equivalent pull request for the log view #1688
There is an equivalent pull request for the tree view which this builds on: #1705
There is an equivalent pull request for the table view which this builds on: #1711
There is an equivalent pull request for the graph view which this builds on: #1717
There is an equivalent pull request for the analysis view which this builds on: #1744

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@markgrahamdawson markgrahamdawson changed the title Use initialOptions prop to save view state Gantt view: use initialOptions to save & restore view state on navigation Apr 9, 2024
@oliver-sanders oliver-sanders added the data workflows team Work pertaining to the analysis/gantt/etc views label Apr 10, 2024
@markgrahamdawson markgrahamdawson self-assigned this Apr 11, 2024
@markgrahamdawson markgrahamdawson marked this pull request as ready for review April 11, 2024 10:32
@markgrahamdawson markgrahamdawson added this to the 2.5.0 milestone Apr 11, 2024
@markgrahamdawson markgrahamdawson added UX/UI User experience and interface improvements small labels Apr 11, 2024
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the conflict (replaced CHANGES.md edit with towncrier fragment)

@MetRonnie
Copy link
Member

@ChrisPaulBennett We don't need a full review from you, but just want to make you aware of this change to the Gantt code

@ChrisPaulBennett ChrisPaulBennett merged commit 7e43234 into cylc:master Apr 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data workflows team Work pertaining to the analysis/gantt/etc views small UX/UI User experience and interface improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants