Avoid calling hyphenToCamelCase twice per note #1683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyphenToCamelCase
from common.stringTools.py currently gets called twice for every note in a piece when importing an xml file. This can be avoided by passing anattributeName
argument when using the_setAttributeFromTagText
method to set the step and octave properties of notes.With this change, when importing a file like:
score = corpus.parse('joplin/maple_leaf_rag.mxl', forceSource=True)
_setAttributeFromTagText
goes from being called over 30k times to about 120 times. Since all the string manipulation in hyphenToCamelCase has no impact on one-word strings, all these avoided calls were unnecessary.