Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small simplifications and speed-ups #1693

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

TimFelixBeyer
Copy link
Contributor

Just some small tweaks in the spirit of #1631 and #1683 that don't change the functionality.

@coveralls
Copy link

coveralls commented Mar 1, 2024

Coverage Status

coverage: 93.034% (+0.002%) from 93.032%
when pulling f8f0978 on TimFelixBeyer:patch-15
into 809ba9d on cuthbertLab:master.

@mscuthbert
Copy link
Member

closing and reopening to update lint.

@mscuthbert mscuthbert closed this Apr 25, 2024
@mscuthbert mscuthbert reopened this Apr 25, 2024
Copy link
Member

@mscuthbert mscuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tim -- really great 90%, but I've asked a couple of times to stop changing code style just because it could be written in another way, and I'm now going to hold off on the PR until those lines are changed back. They don't save the processor any significant time, but they eat up my time in reviewing.

music21/scale/__init__.py Outdated Show resolved Hide resolved
music21/scale/__init__.py Outdated Show resolved Hide resolved
@mscuthbert
Copy link
Member

THANKS! Huge appreciation. Merging!

@mscuthbert mscuthbert merged commit e532560 into cuthbertLab:master Apr 29, 2024
7 checks passed
@TimFelixBeyer
Copy link
Contributor Author

Hi Tim -- really great 90%, but I've asked a couple of times to stop changing code style just because it could be written in another way, and I'm now going to hold off on the PR until those lines are changed back. They don't save the processor any significant time, but they eat up my time in reviewing.

I’m not doing this to annoy you, I usually just work with a very heavily modified version of m21 and sometimes some of my other changes slip in. I will be more careful when making PRs to music21 main in the future to make sure only the most important changes are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants