-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small simplifications and speed-ups #1693
Conversation
closing and reopening to update lint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tim -- really great 90%, but I've asked a couple of times to stop changing code style just because it could be written in another way, and I'm now going to hold off on the PR until those lines are changed back. They don't save the processor any significant time, but they eat up my time in reviewing.
THANKS! Huge appreciation. Merging! |
I’m not doing this to annoy you, I usually just work with a very heavily modified version of m21 and sometimes some of my other changes slip in. I will be more careful when making PRs to music21 main in the future to make sure only the most important changes are included. |
Just some small tweaks in the spirit of #1631 and #1683 that don't change the functionality.