Revert achievement ii #546
Conversation
dhenkel92
force-pushed
the
revert-achievement-ii
branch
from
39b75fc
to
4669d93
Compare
dhenkel92
force-pushed
the
revert-achievement-ii
branch
2 times, most recently
from
59b0fd0
to
1b2f350
Compare
| @@ -135,6 +160,7 @@ const ImportantInformation: React.FC<Props> = ({ variant }) => { | |||
| const pupil = data?.me?.pupil; | |||
| const student = data?.me?.student; | |||
| const email = data?.me?.email; | |||
| const nextStepAchievements: Achievement[] = !GAMIFICATION_ACTIVE ? [] : data?.me.nextStepAchievements ?? []; | |||
There was a problem hiding this comment.
I think we can remove the feature toggle
| progressDescription | ||
| actionName | ||
| actionRedirectLink | ||
| } |
There was a problem hiding this comment.
Maybe as an additional safeguard (and I think it generally makes sense) we could maybe slightly defer the ImportantInformation query a bit (useLazyQuery + useEffect with timeout that triggers it) so that other parts of the page load first and then we have plenty of time to fetch these? For sure we would then make sure that adding the important notifications does not cause a layout shift ...
| @@ -289,6 +320,8 @@ const ImportantInformation: React.FC<Props> = ({ variant }) => { | |||
| }); | |||
|
|
|||
| // -------- Certificate of Conduct ----------- | |||
| // TODO - remove if achievements are included [ONBOARDING]? | |||
There was a problem hiding this comment.
No, need to keep it - Support can request this even if the user is not currently registering - Or would this show up as a ghost?
| @@ -190,6 +218,7 @@ const ImportantInformation: React.FC<Props> = ({ variant }) => { | |||
| }); | |||
|
|
|||
| // -------- Screening ----------- | |||
| // TODO - remove if achievements are included | |||
There was a problem hiding this comment.
What if already screened users request another screening - e.g. students screened as tutors want to be screened as instructors?
|
The achievement cards lack a subtitle ... |
dhenkel92
force-pushed
the
revert-achievement-ii
branch
from
1b2f350
to
9e72b17
Compare
No description provided.