Feat/derived achievements in important information #1090

dhenkel92 · 2024-05-23T15:31:51Z

No description provided.

dhenkel92 · 2024-05-29T10:15:24Z

common/achievement/create.ts

@@ -67,7 +67,7 @@ async function _createAchievement<ID extends ActionID>(currentTemplate: achievem
    // Consequently, the screening process would trigger the creation of the Onboarding achievement, implying several steps that are inappropriate for the student.
    // Thus, the line below ensures that only the current or subsequent achievement steps are created, while others are automatically bypassed.
    // Note: +1 is added because the index is 0-based, while the groupOrder is 1-based.
-    if (nextStepIndex + 1 < currentTemplate.groupOrder) {
+    if (templatesForGroup[nextStepIndex].groupOrder + 1 < currentTemplate.groupOrder) {


I have no idea if this will break anything. Need to check.

graphql/user/fields.ts

common/achievement/derive.ts

common/notification/actions.ts

dhenkel92 · 2024-09-11T18:58:09Z

You can test it here

https://user-app-revert-achieve-m8qo7z.herokuapp.com/start

This is the frontend PR

corona-school/user-app#546

Jonasdoubleyou

Looks good overall!

Jonasdoubleyou · 2024-09-11T19:03:18Z

common/achievement/derive.ts

+        });
+    }
+
+    console.log('iso', hasRequest, hasSuccessfulScreening, achievement);


Jonasdoubleyou · 2024-09-11T19:04:00Z

common/achievement/derive.ts

+        context: ctx,
+        recordValue: null,
+        achievedAt: new Date(),
+        // achievedAt: hasRequest || achievement ? new Date() : null,


the comment looks correct?

Jonasdoubleyou · 2024-09-11T19:05:10Z

common/achievement/derive.ts

+
+async function derivePupilMatching(user: User, pupil: Pupil, result: achievement_with_template[], userAchievements: achievement_with_template[]) {
+    const hasRequest = pupil.openMatchRequestCount > 0;
+    const successfulScreenings = await prisma.pupil_screening.findMany({


.count(...) might be faster.

Good catch!

Jonasdoubleyou · 2024-09-11T19:06:38Z

common/achievement/derive.ts

+    if (successfulScreenings.length > 0) {
+        ctx.lastScreeningDate = successfulScreenings[0].updatedAt.toISOString();
+    }
+    // This case happens when the student just registered and had a successful screening


typo: pupil

Jonasdoubleyou · 2024-09-11T19:07:11Z

common/achievement/derive.ts

+
+async function deriveStudentMatching(user: User, student: Student, result: achievement_with_template[], userAchievements: achievement_with_template[]) {
+    const hasRequest = student.openMatchRequestCount > 0;
+    const successfulScreenings = await prisma.screening.findMany({


Jonasdoubleyou · 2024-09-11T19:07:55Z

common/achievement/derive.ts

+    ctx: StudentNewMatchGhostContext
+): Promise<achievement_with_template[]> {
+    const result: achievement_with_template[] = [];
+    // Generating a ramdom relation to be able to show multiple sequences of this kind in parallel


typo: ramdom

Jonasdoubleyou · 2024-09-11T19:10:09Z

common/achievement/get.ts

@@ -156,6 +162,9 @@ const assembleAchievementData = async (userAchievements: achievements_with_templ
        where: { group: userAchievements[currentAchievementIndex].template.group, isActive: true },
        orderBy: { groupOrder: 'asc' },
    });
+    const derivedTemplates = deriveAchievementTemplates(userAchievements[currentAchievementIndex].template.group);
+    achievementTemplates.push(...derivedTemplates);
+    achievementTemplates.sort((left, right) => left.groupOrder - right.groupOrder);


this looks strange - shouldn't it sort by group AND groupOrder? Or why by groupOrder?

Because in this case all achievements in the list are of the same group

common/notification/actions.ts

Jonasdoubleyou · 2024-09-11T19:15:21Z

common/notification/actions.ts

@@ -602,6 +610,20 @@ const _notificationActions = {
            appointment: sampleAppointment,
        },
    },
+    pupil_create_new_match_chat: {
+        description: 'User has clicked on new chat with a match partner',


Tutee / Created a new chat with a match partner

Jonasdoubleyou · 2024-09-11T19:15:55Z

common/notification/actions.ts

+        },
+    },
+    student_create_new_match_chat: {
+        description: 'User has clicked on new chat with a match partner',


Tutor / Created a new chat with a match partner

The descriptions show up in the Retool UI, maybe good to distinguish them

realmayus had a problem deploying to backend-feat-derived-ac-ah7edr May 23, 2024 15:35 Failure

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch 3 times, most recently from aab1189 to d52992e Compare May 29, 2024 18:22

dhenkel92 commented May 29, 2024

View reviewed changes

graphql/user/fields.ts Outdated Show resolved Hide resolved

Jonasdoubleyou reviewed May 29, 2024

View reviewed changes

common/achievement/derive.ts Outdated Show resolved Hide resolved

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from c6e3d33 to 0cfdc3f Compare June 2, 2024 21:59

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch 2 times, most recently from e3200d3 to b1e29e1 Compare June 18, 2024 18:04

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from b1e29e1 to 32415fc Compare August 16, 2024 11:59

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from 32415fc to 8ad1771 Compare September 8, 2024 13:49

dhenkel92 temporarily deployed to backend-feat-derived-ac-mqgaot September 8, 2024 14:21 Inactive

dhenkel92 had a problem deploying to backend-feat-derived-ac-mqgaot September 8, 2024 16:49 Failure

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from af9e8d0 to 723cc50 Compare September 8, 2024 17:55

dhenkel92 had a problem deploying to backend-feat-derived-ac-mqgaot September 8, 2024 17:55 Failure

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from 723cc50 to 8f67f13 Compare September 8, 2024 17:58

dhenkel92 had a problem deploying to backend-feat-derived-ac-mqgaot September 8, 2024 17:58 Failure

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from 8f67f13 to bc9af4a Compare September 8, 2024 18:04

dhenkel92 temporarily deployed to backend-feat-derived-ac-mqgaot September 8, 2024 18:04 Inactive

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from bc9af4a to 5150828 Compare September 8, 2024 18:15

dhenkel92 temporarily deployed to backend-feat-derived-ac-mqgaot September 8, 2024 18:16 Inactive

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from 5150828 to 3e254be Compare September 11, 2024 10:13

dhenkel92 temporarily deployed to backend-feat-derived-ac-mqgaot September 11, 2024 10:14 Inactive

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from 3e254be to f1252a5 Compare September 11, 2024 18:07

dhenkel92 temporarily deployed to backend-feat-derived-ac-mqgaot September 11, 2024 18:08 Inactive

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from f1252a5 to dbfb1f0 Compare September 11, 2024 18:28

dhenkel92 temporarily deployed to backend-feat-derived-ac-mqgaot September 11, 2024 18:28 Inactive

dhenkel92 commented Sep 11, 2024

View reviewed changes

common/notification/actions.ts Show resolved Hide resolved

dhenkel92 requested a review from Jonasdoubleyou September 11, 2024 18:58

Jonasdoubleyou marked this pull request as ready for review September 11, 2024 19:01

Jonasdoubleyou reviewed Sep 11, 2024

View reviewed changes

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from dbfb1f0 to 550600b Compare September 14, 2024 13:13

dhenkel92 temporarily deployed to backend-feat-derived-ac-mqgaot September 14, 2024 13:13 Inactive

Jonas Wilms and others added 9 commits October 20, 2024 15:37

feat: Derive Achievements & Important Informations

57501e4

always use ghost achievements for important information

9113836

create ghost achievements and ensure a transition to real ones

2bce9c6

remove achievement state hack

c1acff2

create idea of new important information format

b43bc29

be able to create multiple ghost achievement rows

d4abf1d

derive student achievements

d15f2cb

remove important information user field

0a66dce

create new achievements for first student match

a816211

dhenkel92 force-pushed the feat/derived-achievements-in-important-information branch from 550600b to a816211 Compare October 20, 2024 13:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/derived achievements in important information #1090

Feat/derived achievements in important information #1090

dhenkel92 commented May 23, 2024

dhenkel92 May 29, 2024

dhenkel92 commented Sep 11, 2024

Jonasdoubleyou left a comment

Jonasdoubleyou Sep 11, 2024

Jonasdoubleyou Sep 11, 2024

Jonasdoubleyou Sep 11, 2024

dhenkel92 Sep 14, 2024

Jonasdoubleyou Sep 11, 2024

Jonasdoubleyou Sep 11, 2024

Jonasdoubleyou Sep 11, 2024

Jonasdoubleyou Sep 11, 2024

dhenkel92 Sep 14, 2024

Jonasdoubleyou Sep 11, 2024

Jonasdoubleyou Sep 11, 2024

Feat/derived achievements in important information #1090

Are you sure you want to change the base?

Feat/derived achievements in important information #1090

Conversation

dhenkel92 commented May 23, 2024

Choose a reason for hiding this comment

dhenkel92 commented Sep 11, 2024

Jonasdoubleyou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment