add support for sidecar containers via extraContainers #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Young <[email protected]> . .
Signed-off-by: Devin Young <[email protected]>
4 tasks
jamiees2
pushed a commit
to Asana/coredns-chart
that referenced
this pull request
Apr 4, 2024
* add support for sidecar containers via extraContainers Signed-off-by: Devin Young <[email protected]> . . * fix namespacing Signed-off-by: Devin Young <[email protected]> --------- Signed-off-by: Devin Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
This allows users to specify sidecar containers for CoreDNS via the
extraContainersparameter, and for the autoscaler viaautoscaler.extraContainers. This is necessary for Datadog metrics in EKS Fargate.Which issues (if any) are related?
N/A
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.