add support for sidecar containers via extraContainers (#141)

* add support for sidecar containers via extraContainers Signed-off-by: Devin Young <[email protected]> . . * fix namespacing Signed-off-by: Devin Young <[email protected]> --------- Signed-off-by: Devin Young <[email protected]>
coredns · Oct 2, 2023 · c770242 · c770242
1 parent c5e789b
commit c770242
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 3 deletions.
diff --git a/charts/coredns/Chart.yaml b/charts/coredns/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: coredns
-version: 1.26.0
+version: 1.27.0
 appVersion: 1.11.1
 home: https://coredns.io
 icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -20,5 +20,5 @@ engine: gotpl
 type: application
 annotations:
   artifacthub.io/changes: |
-    - kind: changed
-      description: Upgrade CoreDNS to 1.11.1
+    - kind: added
+      description: Added support for sidecar containers via extraContainers
diff --git a/charts/coredns/README.md b/charts/coredns/README.md
@@ -95,6 +95,7 @@ The command removes all the Kubernetes components associated with the chart and
 | `nodeSelector`                                 | Node labels for pod assignment                                                                                                            | {}                                                           |
 | `tolerations`                                  | Tolerations for pod assignment                                                                                                            | []                                                           |
 | `zoneFiles`                                    | Configure custom Zone files                                                                                                               | []                                                           |
+| `extraContainers`                              | Optional array of sidecar containers                                                                                                      | []                                                           |
 | `extraVolumes`                                 | Optional array of volumes to create                                                                                                       | []                                                           |
 | `extraVolumeMounts`                            | Optional array of volumes to mount inside the CoreDNS container                                                                           | []                                                           |
 | `extraSecrets`                                 | Optional array of secrets to mount inside the CoreDNS container                                                                           | []                                                           |
@@ -136,6 +137,7 @@ The command removes all the Kubernetes components associated with the chart and
 | `autoscaler.livenessProbe.timeoutSeconds`      | When the probe times out                                                                                                                  | `5`                                                          |
 | `autoscaler.livenessProbe.failureThreshold`    | Minimum consecutive failures for the probe to be considered failed after having succeeded.                                                | `3`                                                          |
 | `autoscaler.livenessProbe.successThreshold`    | Minimum consecutive successes for the probe to be considered successful after having failed.                                              | `1`                                                          |
+| `autoscaler.extraContainers`                   | Optional array of sidecar containers                                                                                                      | []                                                           |
 | `deployment.enabled`                           | Optionally disable the main deployment and its respective resources.                                                                      | `true`                                                       |
 | `deployment.name`                              | Name of the deployment if `deployment.enabled` is true. Otherwise the name of an existing deployment for the autoscaler or HPA to target. | `""`                                                         |
 | `deployment.annotations`                       | Annotations to add to the main deployment                                                                                                 | `{}`                                                         |

diff --git a/charts/coredns/templates/deployment-autoscaler.yaml b/charts/coredns/templates/deployment-autoscaler.yaml
@@ -93,3 +93,6 @@ spec:
 {{ toYaml .Values.autoscaler.customFlags | indent 10 }}
         {{- end }}
 {{- end }}
+{{- if .Values.autoscaler.extraContainers }}
+{{ toYaml .Values.autoscaler.extraContainers | indent 8 }}
+{{- end }}
diff --git a/charts/coredns/templates/deployment.yaml b/charts/coredns/templates/deployment.yaml
@@ -134,6 +134,9 @@ spec:
 {{- if .Values.securityContext }}
         securityContext:
 {{- toYaml .Values.securityContext | nindent 10 }}
+{{- end }}
+{{- if .Values.extraContainers }}
+{{ toYaml .Values.extraContainers | indent 8 }}
 {{- end }}
       volumes:
         - name: config-volume

diff --git a/charts/coredns/values.yaml b/charts/coredns/values.yaml
@@ -218,6 +218,11 @@ zoneFiles: []
 #      example.com.   IN A   192.168.99.102
 #      *.example.com. IN A   192.168.99.102
 
+# optional array of sidecar containers
+extraContainers: []
+# - name: some-container-name
+#   image: some-image:latest
+#   imagePullPolicy: Always
 # optional array of extra volumes to create
 extraVolumes: []
 # - name: some-volume-name
@@ -349,6 +354,12 @@ autoscaler:
     failureThreshold: 3
     successThreshold: 1
 
+  # optional array of sidecar containers
+  extraContainers: []
+  # - name: some-container-name
+  #   image: some-image:latest
+  #   imagePullPolicy: Always
+
 deployment:
   enabled: true
   name: ""