Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix defaultEvictor. #254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Attempt to fix defaultEvictor. #254

wants to merge 3 commits into from

Commits on Feb 8, 2019

  1. Attempt to fix defaultEvictor. 

    If `pooledResource` is not a `Resource` (but an `Error`), it won't have `lastIdleTime` thus all ifs are returning `false` meaning the `Resource` (which is already broken in some way) won't get evicted ever, they stay in the pool and this may result in a `ResourceRequest Timed Out` error (b/c all slots are occupied by stuck `Resource`s).
As a solution, `idleTime` is checked, and if it is falsy, the `Resource` gets evicted.

Signed-off-by: Daniel Schopper <[email protected]>
    @scream314
    scream314 committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    65b1cba View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2019

  1. fix TravisCI eslint errors

    @scream314
    scream314 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    ea33338 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. changed JSON.stringify to util.inspect as stringify throws `Typ… 

    …eError: Converting circular structure to JSON` error

Signed-off-by: Daniel Schopper <[email protected]>
    @scream314
    scream314 committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    dd00bb9 View commit details
    Browse the repository at this point in the history