Attempt to fix defaultEvictor. #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `pooledResource` is not a `Resource` (but an `Error`), it won't have `lastIdleTime` thus all ifs are returning `false` meaning the `Resource` (which is already broken in some way) won't get evicted ever, they stay in the pool and this may result in a `ResourceRequest Timed Out` error (b/c all slots are occupied by stuck `Resource`s). As a solution, `idleTime` is checked, and if it is falsy, the `Resource` gets evicted. Signed-off-by: Daniel Schopper <[email protected]>
|
Please someone shed some light how to interpret the eslint errors in the Travis build log, I cannot figure out, what the problem is. |
scream314
force-pushed
the
v3.6.1-fix-DefaultEvictor
branch
from
cafa991
to
ea33338
Compare
|
|
…eError: Converting circular structure to JSON` error Signed-off-by: Daniel Schopper <[email protected]>
|
This is definitely not good as it is, the added |
|
I have reported ResourceRequest Timed Out here. I would like to ask what causes” pooledResource is not a Resource (but an Error)“ @scream314 |
|
Sorry, I cannot work on this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
pooledResourceis not aResource(but anError), it won't havelastIdleTimethus all ifs are returningfalsemeaning theResource(which is already broken in some way) won't get evicted ever, they stay in the pool and this may result in aResourceRequest Timed Outerror (b/c all slots are occupied by stuckResources).As a solution,
idleTimeis checked, and if it is falsy, theResourcegets evicted.Signed-off-by: Daniel Schopper [email protected]