Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds deletecollection verb to components and applications #780

Merged

Conversation

yangcao77
Copy link
Contributor

@naftalysh
Copy link

You need also allow the deletecollection verb to the componentdetectionquery object
The CDQ will eventually be garbage collected by HAS. Deleting the Application will not delete the CDQ

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

Hi @yangcao77. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yangcao77
Copy link
Contributor Author

@naftalysh it's set together along with applications and components, thx

APIGroups: []string{"appstudio.redhat.com"},
Resources: []string{"applications", "components", "componentdetectionqueries"},
Verbs: []string{"get", "list", "watch", "create", "update", "patch", "delete", "deletecollection"},

@alexeykazakov
Copy link
Contributor

/ok-to-test

1 similar comment
@alexeykazakov
Copy link
Contributor

/ok-to-test

@alexeykazakov
Copy link
Contributor

/retest

infra issue

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek MatousJobanek merged commit 0ce643d into codeready-toolchain:master Aug 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants