adds deletecollection verb to components and applications

[yangcao77]

See discussion in slack thread: https://redhat-internal.slack.com/archives/C02FANRBZQD/p1692011366722619

For issue https://issues.redhat.com/browse/RHTAPBUGS-595
ADR change: konflux-ci/architecture#129
toolchain-e2e change: codeready-toolchain/toolchain-e2e#780

[naftalysh]

You need also allow the deletecollection verb to the componentdetectionquery object
The CDQ will eventually be garbage collected by HAS. Deleting the Application will not delete the CDQ

[openshift-ci]

Hi @yangcao77. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[yangcao77]

@naftalysh It's set together along with components and applications, thx

host-operator/deploy/templates/nstemplatetiers/appstudio/spacerole_admin.yaml

Lines 16 to 28 in e73e578

	resources:
	- applications
	- components
	- componentdetectionqueries
	verbs:
	- get
	- list
	- watch
	- create
	- update
	- patch
	- delete
	- deletecollection

[alexeykazakov]

/ok-to-test

[codecov]

Codecov Report

Merging #849 (e73e578) into master (9a0f36c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          52       52           
  Lines        5570     5570           
=======================================
  Hits         4624     4624           
  Misses        774      774           
  Partials      172      172           

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment