Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt text 2 #1624

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Alt text 2 #1624

merged 12 commits into from
Oct 2, 2024

Conversation

simk209
Copy link
Collaborator

@simk209 simk209 commented Sep 24, 2024

Summary

#1574

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 0:37am

@Mephistic
Copy link
Collaborator

It looks like this needs yarn fix

The vercel logs are also showing a bunch of lint errors from the recommended accessibility rules we import in .eslintrc from plugin:jsx-a11y/recommended - those are interesting, but go beyond the scope of this ticket so I'd recommend disabling those and just using the immediately relevant rules for alt text to narrow the scope of this PR.

@Mephistic Mephistic mentioned this pull request Oct 2, 2024
3 tasks
Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@Mephistic Mephistic merged commit 65f8706 into codeforboston:main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants