Alt text #1585
Closed
Alt text #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave alt text, although other accessibility errors are showing when running the linter.
…nents. Have NOT started converting alt text with translation hooks.
simk209
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais,
alexjball and
Mephistic
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mertbagt
approved these changes
Aug 7, 2024
Mephistic
reviewed
Sep 17, 2024
| "partnerLogos":{ | ||
| "NuLaw": "Northeastern School of Law Logo", | ||
| "CodeForBoston": "Code for Boston Logo", | ||
| "OpenCollective":"Open Collective Logo" |
There was a problem hiding this comment.
nit: Since this PR opened, we moved to Partners in Democracy - we may want to cover that as well.
added comma
|
Closing in favor of #1624 - that PR contains these changes and resolves some dependency issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved alt text for most components. Eliminating decorative image alt text and using translation hook. Also added a11y linting rule to check for bigger errors like missing alt text/redundant alt text.
Did NOT yet address issues listed here: https://docs.google.com/document/d/1NEkonYj-Ee7AXIrzlBhM8k0EBc2OmN8qG7Ga48lRrKc/edit
#1574
Checklist
Screenshots
Known issues
Other Blocks
Steps to test/reproduce
Known issue 1:
npm run dev. Go to the Learn page and use devtools to inspect the alt text for the "who", "what", etc images.
Known issue 2:
Inspect the profile image in the navBar.
Other Accessibility Considerations
I am not sure if the Bill Tracker section within the Bill Details page is accessible to people relying on screen readers.