-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace buggy UL2016 EGM energy correction files (backport of #46046 to 10_6_X) #46138
base: CMSSW_10_6_X
Are you sure you want to change the base?
Replace buggy UL2016 EGM energy correction files (backport of #46046 to 10_6_X) #46138
Conversation
A new Pull Request was created by @SanghyunKo for CMSSW_10_6_X. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
please test |
-1 Failed Tests: RelVals RelVals
|
The CI will fail without the external :( |
please test with cms-data/EgammaAnalysis-ElectronTools#12 |
You will need to backport the tag update in cmsdist as in cms-sw/cmsdist#9448 |
Thanks, the backport PRs in cmsdist are created cms-sw/cmsdist#9449 & cms-sw/cmsdist#9450. |
REMINDER @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9449, please check if they should be merged together |
test parameters:
|
please abort |
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
backport of #46046 Note that this is a bug fix for UL2016 EGM energy correction, and it will change the NanoAOD content. |
Backport of #46046. As same as the main PR, this should be tested & merged together with cms-data/EgammaAnalysis-ElectronTools#12. After that, the tag pointing to the data repo should be updated as well.