Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6.X] Backport the electron & photon energy correction file updates for 10_6_X/gcc700 #9449

Open
wants to merge 1 commit into
base: IB/CMSSW_10_6_X/gcc700
Choose a base branch
from

Conversation

SanghyunKo
Copy link

@SanghyunKo SanghyunKo commented Oct 3, 2024

Backport of the #9448. Detailed discussions on the cms-data/EgammaAnalysis-ElectronTools#12 and cms-sw/cmssw#46046.

Edit: FYI cms-sw/cmssw#46138 (10_6_X backport PR in the main cmssw)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

A new Pull Request was created by @SanghyunKo for branch IB/CMSSW_10_6_X/gcc700.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#46138

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa0666/41949/summary.html
COMMIT: 8b2c5a7
CMSSW: CMSSW_10_6_X_2024-09-29-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9449/41949/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 4, 2024

+externals

This should go in along with cms-sw/cmssw#46138 for next 10.6.X IB/release

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#46138

@smuzaffar smuzaffar changed the title Backport the electron & photon energy correction file updates for 10_6_X/gcc700 [10.6.X] Backport the electron & photon energy correction file updates for 10_6_X/gcc700 Oct 7, 2024
@cmsbuild
Copy link
Contributor

REMINDER @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmssw#46138, please check if they should be merged together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants