Use time_ago_in_words instead of actionview

[etagwerker]

Hey @jnraine,

This PR removes the actionview dependency and replaces it with time_ago_in_words

I believe this will make it easier to support this gem with older versions of ruby.

What do you think?

Thanks!

[jnraine]

I like this fix but I'm concern that the gem we're now using is no longer maintained. Your PR gave me an idea that might support both old and new codebases well. Let me know what you think!

[jnraine]

This gem appears to no longer be maintained. What if we approached this as a progressive enhancement? If actionview is available, use it. If not, just print the timestamp.

It might look something like this:

begin
  require "action_view"
rescue LoadError
  # actionview gem not installed, that's okay.
end

module DateHelpers
  if defined?(ActionView::Helpers::DateHelper)
    include ActionView::Helpers::DateHelper

    def time_ago_in_words(time)
      "#{super(time)} ago"
    end
  else
    # When ActionView isn't available, print ISO8601 formatted string
    def time_ago_in_words(time)
      time.strftime("%Y-%m-%d")
    end
  end
end

class Foo
  include DateHelpers

  def test(time)
    time_ago_in_words(time)
  end
end

puts Foo.new.test(Time.new(2010, 1, 1))

This would allow us to remove ActionView from the Gemfile while maintaining the pretty printing for those who have ActionView.

[etagwerker]

I like the progressive approach. I'll tweak my PR to take that into account.

[etagwerker]

@jnraine I just updated this PR.

In the process of improving BundleReport I thought it was best to move classes to the lib directory. This made it easier for me to add a spec for the GemInfo#age method.

Please check it out.

Thanks!

[mctaylorpants]

Hey @etagwerker,
Since there's a lot of refactoring here and there's likely some newer changes in your upstream fork, I think I'll close this and #14 and open a new PR to backport your upstream changes (Ruby version, refactoring, etc). I'll work on this next week!