-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes/ruby 2 2 syntax error #14
Conversation
This is an attempt to make this gem compatible with Ruby 2.2
@jnraine thanks for your help! I just pushed the changes we worked on. Let me know if there is anything else that could be improved. 👍 |
@jnraine just a gently reminder about this PR, do you think this is good to go? 😄 |
@jnraine I had missed a couple of problems (like using named parameters) -- I just pushed a couple more changes to fix problems running this gem with older ruby versions. |
Closing; see #17 (comment) for more context. |
Hey @jnraine,
This is an attempt to fix #13. Unfortunately it seems that it will generate a spec failure:
I'm not sure what's the best way to fix that issue. It's probably related to dropping
activesupport
as a dependency. Any thoughts about that?Thanks!