Use an Action to install Packer in our GitHub Actions workflows #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manually installing Packer we can instead leverage the hashicorp/setup-packer Action just as we do for Terraform.
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
6 tasks
mcdonnnj
added
the
kraken 🐙
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes our manual shell code to download and install Packer and replaces it with the hashicorp/setup-packer Action.
💭 Motivation and context
We (@jsf9k) discovered an issue in the
ubuntu-24.04GitHub Actions runner image (that will soon be what theubuntu-latesttag references) due to the images no longer coming with Packer or Terraform preinstalled. While discussing backporting the change he was going to make in cisagov/skeleton-packer I discovered that this Action exists and has been a thing. Since we already use the hashicorp/setup-terraform Action to install Terraform, it makes sense to use their hook to install Packer as well.🧪 Testing
Automated tests pass. I also verified functionality in cisagov/skeleton-packer in this workflow run.
✅ Pre-approval checklist