Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependabot ignore directives #195

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 1, 2024

🗣 Description

This pull request ensures that every Action we use in our workflows has a corresponding dependabot ignore directive.

💭 Motivation and context

I noticed that I missed adding the appropriate directive for hashicorp/setup-packer in #187. I also decided to add one for cisagov/setup-env-github-action just to be comprehensive. We currently pull the develop branch so dependabot should never trigger pull requests around this dependency, but we might decide to start versioning that Action in the future so it's better to list it as a precautionary measure.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Add a directive for hashicorp/setup-packer that was missed when it was
added to the `build` workflow. Add a directive for
cisagov/setup-env-github-action that is not strictly necessary since we
currently just pull from the `develop` branch, but is good to have in
case we were to change that in the future.
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality dependencies Pull requests that update a dependency file labels Nov 1, 2024
@mcdonnnj mcdonnnj self-assigned this Nov 1, 2024
@mcdonnnj mcdonnnj requested a review from a team November 1, 2024 16:34
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Nov 1, 2024
@mcdonnnj mcdonnnj added this pull request to the merge queue Nov 1, 2024
Merged via the queue into develop with commit e6afb68 Nov 1, 2024
4 checks passed
@mcdonnnj mcdonnnj deleted the bug/add_missing_dependabot_ignore branch November 1, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality dependencies Pull requests that update a dependency file kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Development

Successfully merging this pull request may close these issues.

3 participants